Skip to content

[RUMS-4657] iOS: fix parsing of custom RUM timestamps#945

Merged
marco-saia-datadog merged 1 commit into
developfrom
marcosaia/RUMS-4657/fix-ios-rum-timestamps
Jul 23, 2025
Merged

[RUMS-4657] iOS: fix parsing of custom RUM timestamps#945
marco-saia-datadog merged 1 commit into
developfrom
marcosaia/RUMS-4657/fix-ios-rum-timestamps

Conversation

@marco-saia-datadog

Copy link
Copy Markdown
Member

What does this PR do?

Fixes parsing of custom RUM timestamps through attribute _dd.timestamp.

Motivation

The expected type on the iOS SDK is Int64, while we are currently passing a Double.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner July 23, 2025 11:34
maxep
maxep previously approved these changes Jul 23, 2025

@maxep maxep left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cdn34dd
cdn34dd previously approved these changes Jul 23, 2025
@marco-saia-datadog marco-saia-datadog dismissed stale reviews from cdn34dd and maxep via 2f93b15 July 23, 2025 12:22
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUMS-4657/fix-ios-rum-timestamps branch from 9d4a87d to 2f93b15 Compare July 23, 2025 12:22
@marco-saia-datadog marco-saia-datadog merged commit 5c6dfe6 into develop Jul 23, 2025
10 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUMS-4657/fix-ios-rum-timestamps branch July 23, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants