Skip to content

[RUMS-4657] iOS: fix parsing of custom RUM timestamps #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marco-saia-datadog merged 1 commit into from
Jul 23, 2025
Merged

[RUMS-4657] iOS: fix parsing of custom RUM timestamps #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/ios/Sources/DdRumImplementation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ public class DdRumImplementation: NSObject {

private func attributes(from context: NSDictionary, with timestampMs: Double) -> [String: Encodable] {
var context = context as? [String: Any] ?? [:]
context[Self.timestampKey] = timestampMs
context[Self.timestampKey] = Int64(timestampMs)
return castAttributesToSwift(context)
}

Expand Down
20 changes: 10 additions & 10 deletions packages/core/ios/Tests/DdRumTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStopView() throws {
Expand All @@ -68,7 +68,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStartAction() throws {
Expand All @@ -80,7 +80,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStopActionWithoutStarting() {
Expand All @@ -99,7 +99,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testAddAction() throws {
Expand All @@ -111,7 +111,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStartResource() throws {
Expand All @@ -123,7 +123,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStopResource() throws {
Expand All @@ -135,7 +135,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStopResourceWithMissingSize() throws {
Expand All @@ -147,7 +147,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testStopResourceWithExternalTimings() throws {
Expand Down Expand Up @@ -230,7 +230,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testAddError() throws {
Expand All @@ -242,7 +242,7 @@ internal class DdRumTests: XCTestCase {
let lastAttributes = try XCTUnwrap(mockNativeRUM.receivedAttributes.last)
XCTAssertEqual(lastAttributes.count, 2)
XCTAssertEqual(lastAttributes["foo"] as? Int64, 123)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Double, randomTimestamp)
XCTAssertEqual(lastAttributes[DdRumImplementation.timestampKey] as? Int64, Int64(randomTimestamp))
}

func testAddTiming() throws {
Expand Down
Loading