-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: check for new majors in v2 #3078
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 4088 Passed, 64 Skipped, 2m 39.44s Total Time |
BenchmarksBenchmark execution time: 2025-02-10 18:18:03 Comparing candidate commit 17e36d8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 0 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Overall looks good to me, just a few comments
Datadog ReportBranch report: ❌ 21 Failed (1 Known Flaky), 2623 Passed, 67 Skipped, 1m 30.87s Total Time ❌ Failed Tests (21)
|
c85378d
to
a92f304
Compare
rebased and force pushed as the workflow yml was updated |
What does this PR do?
Checks for new major versions on github in v2
Motivation
In the original PR, we used a hardcoded, manual
integration_go.mod
to detect if new major versions (corresponding to new packages) have been released. However, inv2
each package will be treated as its own contrib with its own correspondinggo.mod
. We want to parse thesego.mod
files to check the currentlatest
major, and output if a new major is available.Check the latest major we support for a given package / module (parsing the
go.mod
files).Fetch / check for new major versions from github:
go list -m -json <repository>@<version>
and extractOrigin[url]
git ls-remote --tags <repository>
curl https://raw.githubusercontent.com/<module>/refs/tags/<latest_version>/go.mod
404
, the module is not a go module and we can skip it"New latest major on Github: {github_latest_major}"
Example output from workflow run: https://github.com/DataDog/dd-trace-go/actions/runs/12993810647/job/36236846230
TODO:
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!