fix: pin all contribs to dd-trace-go v2.1.0-dev & adjust AWS SDK v2 versions #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
Datadog ReportBranch report: ✅ 0 Failed, 4381 Passed, 65 Skipped, 3m 42.62s Total Time |
BenchmarksBenchmark execution time: 2025-03-11 20:42:33 Comparing candidate commit 666c286 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics. |
…add hardcoded instrumentation/testutils/grpc/v2 module
darccio
force-pushed
the
dario.castane/aws-sdk-stable-deps
branch
from
ac15da9 to
6d96634
Compare
darccio
commented
Mar 11, 2025
Comment on lines
+111
to
+115
| // Add the instrumentation/testutils/grpc/v2 module to the identified modules. | ||
| // Adding the package to the paths causes issues. | ||
| instTestutilsGRPC := "github.com/DataDog/dd-trace-go/instrumentation/testutils/grpc/v2" | ||
| modules[instTestutilsGRPC] = filepath.Join(rootDir, "instrumentation", "testutils", "grpc") | ||
|
|
There was a problem hiding this comment.
@RomainMuller I had to introduce this "detected" module to fix the CI after pinning all the modules against v2.1.0-dev, those having the corresponding replace directives.
7 tasks
darccio
added a commit
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes sure that AWS SDK v2 versions are aligned with
main. It also pins all modules withreplacedirectives againstv2.1.0-dev.Motivation
It avoids accidental upgrades coming from non-production packages like
google.golang.org/grpc/examples, as they propagate throughgo.work.sumand leads to failing CI as not all related packages are not updated properly.Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!