Skip to content

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Dec 2, 2025

Description

This PR add a readyness check on the Symfony cache app in case the service is unavailable.
The absence of this check can be the cause for significant latency increase when the cache app is not available as we are fetching all the routes in that case.

@Leiyks Leiyks changed the title feat(Integrations: Symfony): Check the caching system is reachable be… feat(Symfony): Check cache.app is reachable before use Dec 2, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 2, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-03 16:02:16

Comparing candidate commit ea33259 in PR branch leiyks/APMS-17485 with baseline commit 2790073 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-6.540µs; -5.580µs] or [-5.984%; -5.106%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-3.638µs; -2.342µs] or [-3.259%; -2.098%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-51.710µs; -42.990µs] or [-11.200%; -9.311%]

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.69%. Comparing base (2790073) to head (ea33259).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3514      +/-   ##
==========================================
- Coverage   61.81%   61.69%   -0.12%     
==========================================
  Files         142      142              
  Lines       12923    12923              
  Branches     1695     1695              
==========================================
- Hits         7988     7973      -15     
- Misses       4183     4196      +13     
- Partials      752      754       +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2790073...ea33259. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Leiyks Leiyks force-pushed the leiyks/APMS-17485 branch 6 times, most recently from 7b789c3 to 84db2cc Compare December 3, 2025 14:49
@Leiyks Leiyks force-pushed the leiyks/APMS-17485 branch from 84db2cc to ea33259 Compare December 3, 2025 14:57
@Leiyks Leiyks marked this pull request as ready for review December 3, 2025 14:57
@Leiyks Leiyks requested a review from a team as a code owner December 3, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants