Skip to content

feat(Symfony): Check cache.app is reachable before use #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leiyks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(Symfony): Check cache.app is reachable before use #3514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/DDTrace/Integrations/Symfony/SymfonyIntegration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,57 @@ static function() {
if (!\method_exists($cache, 'getItem')) {
return;
}

// Check if the cache adapter is actually accessible before trying to use it
if (\method_exists($cache, 'getAdapter')) {
try {
$adapter = $cache->getAdapter();

if (
$adapter instanceof \Symfony\Component\Cache\Adapter\RedisAdapter ||
$adapter instanceof \Symfony\Component\Cache\Adapter\RedisTagAwareAdapter
) {
$reflection = new \ReflectionClass($adapter);
$redisProperty = $reflection->getProperty('redis');
$redisProperty->setAccessible(true);
$redis = $redisProperty->getValue($adapter);

if (\method_exists($redis, 'ping')) {
$pong = $redis->ping();
// ping() returns false when Redis is unavailable
if ($pong === false || $pong === null) {
return;
}
} else {
return;
}
} elseif ($adapter instanceof \Symfony\Component\Cache\Adapter\MemcachedAdapter) {
if (\method_exists($adapter, 'getClient')) {
$client = $adapter->getClient();
// getVersion() return false if the server is not reachable
if (\method_exists($client, 'getVersion')) {
$version = $client->getVersion();
if ($version === false || empty($version)) {
return;
}
}
}
} elseif ($adapter instanceof \Symfony\Component\Cache\Adapter\PdoAdapter) {
if (\method_exists($adapter, 'getConnection')) {
$pdo = $adapter->getConnection();
// getAttribute() throws exception if connection is down
if ($pdo instanceof \PDO) {
$version = $pdo->getAttribute(\PDO::ATTR_SERVER_VERSION);
if ($version === null || $version === false) {
return;
}
}
}
}
} catch (\Exception $e) {
return;
}
}
$itemName = "_datadog.route.path.$route_name";
$locale = $request->get('_locale');
if ($locale !== null) {
Expand Down
Loading