-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[do not merge] run ci with patched ddtrace #21706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| confluent-kafka==2.11.1 | ||
| cryptography==45.0.6 | ||
| ddtrace==3.12.5 | ||
| ddtrace@ {root:uri}/ddtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hard-coding a local Linux wheel for ddtrace
Both dependency lists now point to ddtrace @ {root:uri}/ddtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl. This direct reference requires a wheel sitting at the repository root and is built only for Linux/x86‑64 CPython 3.13. On any other platform—or if the wheel is not checked into the repo—pip will immediately fail to resolve ddtrace, so building or testing the agent from source outside that single environment is no longer possible. Unless the project intends to ship a platform-specific wheel in-tree, this should remain a normal version pin to a published package.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Test Results 686 files 686 suites 5h 0m 10s ⏱️ For more details on these failures and errors, see this check. Results for commit 5ec602f. ♻️ This comment has been updated with latest results. |
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged