Skip to content

[do not merge] run ci with patched ddtrace #21706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[do not merge] run ci with patched ddtrace #21706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58842fb
[do not merge] test with local ddtrace
taegyunkim Oct 20, 2025
50585ff
use local whl file
taegyunkim Oct 20, 2025
e5acc18
force add
taegyunkim Oct 20, 2025
026acb3
trigger on my branch too
taegyunkim Oct 20, 2025
5ec602f
skip windows-2022
taegyunkim Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cache-shared-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-22.04, windows-2022]
os: [ubuntu-22.04]

env:
PYTHON_VERSION: "3.13"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
- taegyunkim/fix-test-hang
paths:
# List of files/paths that should trigger the run. The intention is to avoid running all tests if the commit only includes changes on assets or README
- '*/datadog_checks/**'
Expand Down
2 changes: 1 addition & 1 deletion agent_requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ clickhouse-connect==0.8.18
cm-client==45.0.4
confluent-kafka==2.11.1
cryptography==45.0.6
ddtrace==3.12.5
ddtrace@ {root:uri}/ddtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid hard-coding a local Linux wheel for ddtrace

Both dependency lists now point to ddtrace @ {root:uri}/ddtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl. This direct reference requires a wheel sitting at the repository root and is built only for Linux/x86‑64 CPython 3.13. On any other platform—or if the wheel is not checked into the repo—pip will immediately fail to resolve ddtrace, so building or testing the agent from source outside that single environment is no longer possible. Unless the project intends to ship a platform-specific wheel in-tree, this should remain a normal version pin to a published package.

Useful? React with 👍 / 👎.

dnspython==2.7.0
fastavro==1.12.0
foundationdb==6.3.25
Expand Down
Binary file added ...dtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl
View file
Open in desktop
Binary file not shown.
5 changes: 4 additions & 1 deletion datadog_checks_base/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[build-system]

Check failure on line 1 in datadog_checks_base/pyproject.toml

View workflow job for this annotation

GitHub Actions / run / Validate 

Invalid URL scheme found for dependency `ddtrace`: datadog_checks_base.
requires = [
"hatchling>=0.11.2",
]
Expand Down Expand Up @@ -37,7 +37,7 @@
"binary==1.0.2",
"cachetools==6.2.0",
"cryptography==45.0.6",
"ddtrace==3.12.5",
"ddtrace @ {root:uri}/ddtrace-3.17.0.dev73+g11a526fe2-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.whl",
"jellyfish==1.2.0",
"lazy-loader==0.4",
"prometheus-client==0.22.1",
Expand Down Expand Up @@ -75,6 +75,9 @@
[project.urls]
Source = "https://github.com/DataDog/integrations-core"

[tool.hatch.metadata]
allow-direct-references = true

[tool.hatch.version]
path = "datadog_checks/base/__about__.py"

Expand Down
Loading