Add MacOS build packaging tool #734
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
python3.10 is hardcoded in a few places. We should try to make it easier to upgrade to a new python version in the future, which can happen pretty often. Maybe it is even possible to replace with python3 ? |
OtabekRintaro
force-pushed
the
feature/release-packaging
branch
from
2f413e4 to
051c9ff
Compare
dkuegler
requested changes
Oct 17, 2025
.github/workflows/deploy.yml
Outdated
| run: | | ||
| mkdir artifact | ||
| mv tools/macos_build/installer/* artifact/ | ||
| - uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Instead of uploading the file as an artifact, upload it as a release asset with this action https://github.com/softprops/action-gh-release .
See also https://docs.github.com/en/rest/releases/assets?apiVersion=2022-11-28
.github/workflows/deploy.yml
Outdated
| ARTIFACT_NAME: FastSurfer | ||
| VERSION: 242 | ||
| FREESURFER_URL: https://surfer.nmr.mgh.harvard.edu/pub/dist/freesurfer/7.4.1/freesurfer-macOS-darwin_x86_64-7.4.1.tar.gz | ||
| UPLOAD_ARTIFACT: true |
There was a problem hiding this comment.
not artifact but release asset
Comment on lines
14
to
17
| if ! grep -q "export PATH=\"$(brew --prefix)/opt/grep/libexec/gnubin:\$PATH\"" ~/.bash_profile; then | ||
| echo "export PATH=\"$(brew --prefix)/opt/grep/libexec/gnubin:\$PATH\"" >> ~/.bash_profile; | ||
| echo "GNU grep has been adde to path" | ||
| fi |
There was a problem hiding this comment.
Make sure run_fastsurfer.sh is also in PATH!
|
We will also need to update the install instructions for macOS in |
OtabekRintaro
force-pushed
the
feature/release-packaging
branch
from
85f3e65 to
d06303d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a tool for packaging MacOS build for FastSurfer and modified workflow to automate packaging on FastSurfer release.
build_release_package.sh script packages FastSurfer along with minimised freesurfer code.
Modified deploy.yml workflow builds and uploads packaged FastSurfers to artifacts on FastSurfer release.