Add basic Github action workflow to run checks#5
Open
n-peugnet wants to merge 1 commit intoDefangLabs:mainfrom
Open
Add basic Github action workflow to run checks#5n-peugnet wants to merge 1 commit intoDefangLabs:mainfrom
n-peugnet wants to merge 1 commit intoDefangLabs:mainfrom
Conversation
The tests of this library currently do not pass. It seems upstream developpers didn't care to run the testsuite after making changes, leading to a lot of tests failing. To prevent this situation, it is good to run the build and tests on each push and pull requests to master. This commits adds a very basic GitHub actions workflow for go projects. The composites check of go vet is ignored as the tests make a heavy use of unkeyed struct fields, which leaded to a lot of "struct literal uses unkeyed fields" warnings that are not that important since the package comes from the same repository.
Author
|
See the kind of (currently failing) workflow this produces on my fork: https://github.com/n-peugnet/secret-detector/actions/runs/22065946922/job/63757679095 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand that you probably did not intend to take over upstream development in this fork, but as the previous upstream archived their repository, your fork becomes the most up to date version of this library.
As docker-compose now depends on your fork, I am currently packaging your library in Debian, and noticed that the testsuite does not pass.
It seems upstream developers didn't care to run the testsuite after making changes, leading to a lot of tests failing.
To prevent this situation, it is good to run the build and tests on each push and pull requests to master.
This commits adds a very basic GitHub actions workflow for go projects.
The composites check of go vet is ignored as the tests make a heavy use of unkeyed struct fields, which leaded to a lot of "struct literal uses unkeyed fields" warnings that are not that important since the package comes from the same repository.
As a follow-up, I will send you some patches that fix most of the test failures, but for a few of them, I did not manage to find an easy solution yet. I will try to run
git bisectto find where these few last failing tests stopped passing.