Skip to content

Conversation

ironashram
Copy link
Contributor

Description

  • update node from 18 to 22
  • bump devcontainer base image to ubuntu24
  • update dependencies

Tested in my profile too. (On Vercel side a manual redeploy was needed)

Closes #810

@theck13
Copy link

theck13 commented Aug 29, 2025

Are all these changes required to update Node from 18 to 22 or is the one-line change in package.json enough?

@ironashram
Copy link
Contributor Author

tbh I haven't even tried to bump the node engine alone.
anyway it's just dependency updates, I don't see why one wouldn't want to do those unless they cause incompatibilities which I haven't found

@theck13
Copy link

theck13 commented Aug 29, 2025

Ah, yeah, updating dependencies is a good idea generally. I was just asking more out of curiosity since I'm not a web developer. I only updated the node version in package.json in my fork to make the smallest change required in order to isolate any complications and it appears to work. Both the deployments of my fork and example of my instance shown below look good to me.


GitHub Activity Streaks

@ironashram
Copy link
Contributor Author

ironashram commented Aug 29, 2025

in hindsight one could argue that with all the supply chain attacks plaguing npm packages maybe your minimal change is better, anyway let's see what the maintainer thinks

@Adamou02
Copy link

Is the maintainer still active or do we have to do a fork of the project ?

@theck13
Copy link

theck13 commented Aug 29, 2025

Is the maintainer still active or do we have to do a fork of the project ?

Based on the commits to main, there was a commit co-authored by the maintainer on May 7th. So, I'd say it's still maintained.

I forked the repository in order to deploy your own instance, which I would recommend. If you do that, you can update the node version in package.json to avoid the deprecation on Monday, September 1st.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@DenverCoder1 DenverCoder1 merged commit a43ae37 into DenverCoder1:main Sep 30, 2025
3 checks passed
@stevepiercy
Copy link

Does this need to be ported to the vercel branch, or does the main branch's readme.md link to launch Vercel need to be updated as well? I see the link refers to the vercel branch.

https://vercel.com/new/clone?repository-url=https%3A%2F%2Fgithub.com%2FDenverCoder1%2Fgithub-readme-streak-stats%2Ftree%2Fvercel&env=TOKEN&envDescription=GitHub%20Personal%20Access%20Token%20(no%20scopes%20required)&envLink=https%3A%2F%2Fgithub.com%2Fsettings%2Ftokens%2Fnew%3Fdescription%3DGitHub%2520Readme%2520Streak%2520Stats&project-name=streak-stats&repository-name=github-readme-streak-stats

When I try to deploy this from an altered link with main replacing vercel, then it builds, but the deployment returns an HTTP 404 not found.

@DenverCoder1
Copy link
Owner

The vercel branch should be up to date now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel is deprecating Node 18
5 participants