Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: fix linting problems #156

Open
2 tasks done
leon1995 opened this issue May 10, 2023 · 1 comment · Fixed by #248, #253 or #399
Open
2 tasks done

feature: fix linting problems #156

leon1995 opened this issue May 10, 2023 · 1 comment · Fixed by #248, #253 or #399
Labels
enhancement New feature or request v2 Version 2 is affected

Comments

@leon1995
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Feature idea

fix issues found by linter

Alternatives

Implementation idea

No response

Participation

  • I am willing to submit a pull request to implement this feature.

Link to the idea discussion

No response
@leon1995 leon1995 added the enhancement New feature or request label May 10, 2023
@leon1995
Copy link
Member Author

leon1995 commented Jul 5, 2023

relates to #194 #157

@leon1995 leon1995 mentioned this issue Jul 10, 2023
Merged
5 tasks
@a-kleinf a-kleinf added the v2 Version 2 is affected label Aug 22, 2023
leon1995 added a commit to leon1995/sdc11073 that referenced this issue Aug 31, 2023
@leon1995
fix RUF012 Draegerwerk#156
d93319e
@leon1995 leon1995 mentioned this issue Aug 31, 2023
Merged
5 tasks
@leon1995 leon1995 linked a pull request Sep 1, 2023 that will close this issue
fixed all lint findings that appeared under 4 times #253
Merged
5 tasks
leon1995 added a commit that referenced this issue Sep 6, 2023
@leon1995
fix RUF012 #156 (#248)
1240d2b 
part of linting fix #156 . this fixes `RUF012`

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have updated the [changelog](../CHANGELOG.md) accordingly.
- [ ] I have added tests to cover my changes.
@leon1995 leon1995 reopened this Sep 7, 2023
@leon1995 leon1995 reopened this Sep 18, 2023
@leon1995 leon1995 mentioned this issue Oct 5, 2023
Merged
5 tasks
leon1995 added a commit that referenced this issue Oct 5, 2023
@leon1995
fix TID252 (#270)
1a5954a 
<!--- Provide a general summary of your changes in the title above -->
<!--- Link the corresponding issues after you created the pull request
-->
fixes [TID252](https://docs.astral.sh/ruff/rules/relative-imports/)

can be verified with `ruff check . --select TID252`

#156 

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] I have updated the [changelog](../CHANGELOG.md) accordingly.
- [ ] I have added tests to cover my changes.
@leon1995 leon1995 linked a pull request Nov 14, 2024 that will close this issue
use official ruff action #399
Merged
5 tasks
@leon1995 leon1995 reopened this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v2 Version 2 is affected
Projects
None yet
Milestone
No milestone
2 participants
@leon1995 @a-kleinf