fix: add cwd option to npm execFileSync to prevent uv_cwd error under systemd#1043
Open
kalier021 wants to merge 1 commit into
Open
fix: add cwd option to npm execFileSync to prevent uv_cwd error under systemd#1043kalier021 wants to merge 1 commit into
kalier021 wants to merge 1 commit into
Conversation
… error When hermes-web-ui runs under systemd with WorkingDirectory pointing to the web-ui install directory, the npm subprocess inherits this cwd. During 'npm install -g hermes-web-ui@latest', npm replaces files in that directory, invalidating the process current working directory and causing ENOENT: no such file or directory, uv_cwd. Fix: pass cwd: homedir() to execFileSync so npm runs from the user home directory instead of the web-ui install directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When hermes-web-ui runs under systemd with WorkingDirectory pointing to the web-ui install directory, the npm subprocess spawned by runNpm() inherits this cwd. During 'npm install -g hermes-web-ui@latest', npm replaces files in that directory, invalidating the process current working directory and causing:
This causes the Web UI built-in Update button to return HTTP 500 when running under systemd.
Fix
Add cwd: homedir() to the execFileSync call in runNpm() so npm runs from the user home directory instead of the web-ui install directory.
Changes
Verification
Tested on production system running hermes-web-ui v0.6.1 under systemd. The /api/hermes/update endpoint previously returned 500 with uv_cwd error. After the fix, npm subprocess runs from the home directory without cwd errors.