Skip to content

Conversation

blacklight
Copy link
Collaborator

Apparently we can't always assume that the JSON object passed to parse_playlist always contains a data envelope.

Closes: #349

Apparently we can't always assume that the JSON object passed to
`parse_playlist` always contains a `data` envelope.

Closes: EbbLabs#349
@blacklight blacklight requested a review from tehkillerbee July 29, 2025 19:22
@blacklight blacklight self-assigned this Jul 29, 2025
@blacklight
Copy link
Collaborator Author

@tehkillerbee let me know if this may be due to recent changes in the API layer or if there's a better way to handle this.

@blacklight
Copy link
Collaborator Author

Ok I've actually noticed that this is the same thing as this #345

@tehkillerbee not sure if you made some progress about this, but it looks like my workaround of fetching data and using the object itself as root as the fallback works. But I've just given it a try in high-tide and it seems that if I have large playlists I can't fetch more than 50 objects (not sure if it's an issue on our side though, or if it should now be the client to handle paginated requests).

@tehkillerbee
Copy link
Collaborator

tehkillerbee commented Jul 29, 2025

not sure if you made some progress about this, but it looks like my workaround of fetching data and using the object itself as root as the fallback work

The v2 endpoints require no more than 50 objects per fetch. So pagination should be used for large lists. Anyways, I plan to add the threaded worker threads to tidalapi and then they can be used when fetching larger sets of playlists, similar to what we do in mopidy tidal.

This fix is still a good idea so lets merge it 👍

@tehkillerbee tehkillerbee merged commit b60f15a into EbbLabs:main Jul 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching isn't working
2 participants