-
Notifications
You must be signed in to change notification settings - Fork 167
fix: update import to new path #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR updates the Docker Compose configuration to use a local build image and include a .env file, and corrects the MCPService import path to the new adk submodule. Class Diagram: Relocated MCPService DependencyclassDiagram
class src_utils_mcp_discovery {
<<Python Module>>
+ _discover_async(config_json) List~Dict~
}
class src_services_adk_MCPService {
<<Python Class>>
+ MCPService()
# _connect_to_mcp_server(config_json)
}
src_utils_mcp_discovery ..> src_services_adk_MCPService : imports and uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Danielpeter-99 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| services: | ||
| api: | ||
| image: evoapicloud/evo-ai:latest | ||
| # image: evoapicloud/evo-ai:latest Use this image to pull from the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider using a separate override file instead of commenting out production image
Using docker-compose.override.yml for environment-specific images keeps the main file clean and prevents outdated commented code.
Suggested implementation:
image: evoapicloud/evo-ai:latest # Use this image to pull from the repo
Create a new file named docker-compose.override.yml with the following content to use the local image for development:
services:
api:
image: evoai-api:latest # Use this image for local buildsThis way, the main docker-compose.yml always uses the production image, and local development can override it cleanly.
| api: | ||
| image: evoapicloud/evo-ai:latest | ||
| # image: evoapicloud/evo-ai:latest Use this image to pull from the repo | ||
| image: evoai-api:latest # Use this image for local builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Avoid using ‘latest’ tag for local builds to prevent confusion with remote images
Using the same 'latest' tag for both local and remote images can cause Docker to pull the wrong image. Use a unique tag like 'local' or 'dev' for local builds.
| image: evoai-api:latest # Use this image for local builds | |
| image: evoai-api:local # Use this image for local builds |
Summary by Sourcery
Update MCPService import path and enhance docker-compose configuration
Bug Fixes:
Deployment: