Skip to content

fix: update import to new path #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidsonGomes merged 2 commits into from
Jun 2, 2025
Merged

fix: update import to new path #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840e554
fix: update import to new path
Danielpeter-99 May 29, 2025
17524e5
fix: adding local build image, adding local .env to docker compose
Danielpeter-99 May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@ version: "3.8"

services:
api:
image: evoapicloud/evo-ai:latest
# image: evoapicloud/evo-ai:latest Use this image to pull from the repo
Copy link

@sourcery-ai sourcery-ai bot May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a separate override file instead of commenting out production image

Using docker-compose.override.yml for environment-specific images keeps the main file clean and prevents outdated commented code.

Suggested implementation:

    image: evoapicloud/evo-ai:latest # Use this image to pull from the repo

Create a new file named docker-compose.override.yml with the following content to use the local image for development:

services:
  api:
    image: evoai-api:latest # Use this image for local builds

This way, the main docker-compose.yml always uses the production image, and local development can override it cleanly.

image: evoai-api:latest # Use this image for local builds
Copy link

@sourcery-ai sourcery-ai bot May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid using ‘latest’ tag for local builds to prevent confusion with remote images

Using the same 'latest' tag for both local and remote images can cause Docker to pull the wrong image. Use a unique tag like 'local' or 'dev' for local builds.

Suggested change
image: evoai-api:latest # Use this image for local builds
image: evoai-api:local # Use this image for local builds

depends_on:
- postgres
- redis
ports:
- "8000:8000"
env_file:
- .env
environment:
POSTGRES_CONNECTION_STRING: postgresql://postgres:${POSTGRES_PASSWORD:-postgres}@postgres:5432/evo_ai
REDIS_HOST: redis
Expand Down
3 changes: 1 addition & 2 deletions src/utils/mcp_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@

async def _discover_async(config_json: Dict[str, Any]) -> List[Dict[str, Any]]:
"""Return a list[dict] with the tool metadata advertised by the MCP server."""

from src.services.mcp_service import MCPService
from src.services.adk.mcp_service import MCPService

service = MCPService()
tools, exit_stack = await service._connect_to_mcp_server(config_json)
Expand Down
Loading