Remove prod guard for selfDM splits feature - #91995
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08da4df8ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
All this is doing is making this feature available because we've been working on polishing it the last few months, and it's now in a good state. Is that correct? |
Yep |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.61-0 🚀
|
|
Yes — a help-site update is required. This PR removes the The Split Expenses article's "Who can split expenses" section still said unreported expenses were excluded from splitting "but this functionality will be available soon" — that caveat is now outdated. I created a draft help-site PR updating that eligibility line. 📝 Draft docs PR: #99477 Docs change
The rest of the article's split flow (More > Split, Add split, Save, etc.) already applies to self-DM expenses unchanged, so no other edits were needed. UI verification (web): ✅ pass — created a manual expense in the self-DM, opened its details, and confirmed the More menu shows Split, which opens a working split editor.
Evidence (3)Self-DM chat opened from Inbox
Expense details view with More button
Split editor with two rows, Add split, Make splits even, Save
@ZhenjaHorbach, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@ZhenjaHorbach @lakchote @dmkt9 To confirm, Do we have to validate this PR in Production? |
@m-natarajan you should verify that the splits for unreported expenses are still working correctly on staging, and then when it hits production verify that the split option is available for unreported expenses |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀
Bundle Size Analysis (Sentry): |



Explanation of Change
Fixed Issues
$ #91999
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-05-28.15.55.19.mov