restore invited login when OpenReport settles the participant without one by mukhrr · Pull Request #95594 · Expensify/App

mukhrr · 2026-07-08T13:36:23Z

Explanation of Change

Fixed Issues

$ #92581
PROPOSAL: #92581 (comment)

Tests

Click on FAB > Start chat
Enter an expensifail account address (eg. applausertester+testemail@applause.expensifail.com)
Open the conversation
Click on the account header

Verify login detail displays "Email" and the email
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Uploading 92581-android-app.mp4…

Android: mWeb Chrome

92581-android-web.mp4

iOS: Native

92581-ios-app.mp4

iOS: mWeb Safari

92581-ios-web.mp4

MacOS: Chrome / Safari

92581-web.mp4

… one

codecov · 2026-07-08T13:41:17Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Middleware/HandleUnusedOptimisticID.ts	`98.73% <100.00%> (+0.95%)`	⬆️
src/libs/actions/Report/index.ts	`71.25% <100.00%> (+0.61%)`	⬆️
... and 310 files with indirect coverage changes

melvin-bot · 2026-07-09T02:51:37Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mukhrr · 2026-07-09T03:12:11Z

~~failing tests are not related. I think it's being fixed in #95654~~

…ertions Narrow request.data.emailList with a typeof check instead of a bare template-string coercion, and replace (global.fetch as jest.Mock) casts with jest.spyOn(HttpUtils, 'xhr') so the new middleware tests type-check without unsafe assertions. Also restructure the participants for-in loop back into a single guard if to satisfy guard-for-in.

brunovjk · 2026-07-10T14:14:00Z

@codex review

chatgpt-codex-connector · 2026-07-10T14:22:28Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: bf2b0d840d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

brunovjk · 2026-07-10T15:21:47Z

The main OpenReport reconciliation looks good to me and matches the accepted RCA.

One thing I think we should adjust before approval: the generic login === '' sanitizer in HandleUnusedOptimisticID seems too broad. It runs for any response containing PERSONAL_DETAILS_LIST, not just this OpenReport/PublicProfile flow, and the confirmed backend behavior is that OpenPublicProfilePage omits login rather than sending login: ''.

@mukhrr @inimaga What do you think about remove that block, or scope it very explicitly with a unit test if it is still needed? Thank you.

The sanitizer previously ran for the response of any API command that included a PERSONAL_DETAILS_LIST merge with an empty login, not just the OpenReport/profile flow it exists for. Narrow it to the one command it's meant to guard against, and add tests covering both that it still fixes OpenPublicProfilePage and that it now leaves other commands alone.

mukhrr · 2026-07-12T09:49:59Z

@brunovjk you’re right that it was running for every response, not just this flow. I’ve narrowed it to OpenPublicProfilePage specifically:

App/src/libs/Middleware/HandleUnusedOptimisticID.ts

Lines 174 to 188 in 93a3d4f

    
           // OpenPublicProfilePage can echo back an explicitly empty login for an account the client 
        
           // already knows a login for; drop that so it can't blank out the value we already have. 
        
           if (request?.command === READ_COMMANDS.OPEN_PUBLIC_PROFILE_PAGE) { 
        
               for (const update of response?.onyxData ?? []) { 
        
                   if (update.key !== ONYXKEYS.PERSONAL_DETAILS_LIST || !isRecord(update.value)) { 
        
                       continue; 
        
                   } 
        
                   for (const [accountID, detail] of Object.entries(update.value)) { 
        
                       if (!isRecord(detail) || detail.login !== '' || !getLoginByAccountID(Number(accountID))) { 
        
                           continue; 
        
                       } 
        
                       delete detail.login; 
        
                   } 
        
               } 
        
           }

brunovjk · 2026-07-14T19:06:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-07-14.at.16.04.38.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-14.at.15.56.05.mov

brunovjk

LGTM, but we have conflicts to resolve, @mukhrr. Thanks.

Resolved prepareOnyxDataForCleanUpOptimisticParticipants both ways: kept upstream's (personalDetails, currentUserAccountID) params and current-user skip (Expensify#95427 avatar flicker fix), kept our missingLoginParticipants collection and the middleware's invitedEmails capture; extended upstream's new ReportTest expectations with the missingLoginParticipants field. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

inimaga · 2026-07-15T17:16:23Z

+                    if (!isRecord(detail) || detail.login !== '' || !getLoginByAccountID(Number(accountID))) {
+                        continue;
+                    }
+                    delete detail.login;


login: '' is not the same as a missing login. We should only restore the typed email only when the backend leaves login out. If the backend sends an explicit empty login (which is possible), we should respect it, otherwise we may show an old email for an account that should stay hidden. Could you please check for the login key being absent instead of using a falsy check. Also retrospectively fix this for other parts of the code.

inimaga · 2026-07-16T10:34:30Z

+            redundantParticipants[accountID] = null;
+        } else if (personalDetails?.[accountID] && !personalDetails[accountID].login) {
+            // '' counts as missing: SearchForReports seeds login: '' for unvalidated accounts, and in Onyx the two are indistinguishable
+            missingLoginParticipants.push(Number(accountID));


in Onyx the two are indistinguishable

This doesn't seem correct to me. They are distinguishable by checking whether the login key exists. You should use !Object.hasOwn(personalDetail, 'login') instead of !personalDetails[accountID].login.

The point is login: '' can be intentional, so we should not treat it as missing or delete it from responses. Please apply the same “missing key only” rule to the OpenPublicProfilePage handling.

hmm yes that makes sense to me. thanks

inimaga

Nice! Thanks for handling. 🚀

OSBotify · 2026-07-16T11:49:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-16T11:52:41Z

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-16T11:57:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95594.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5a9eb7c50a0-84c49dd-5a021d4fe9ae75735fc026dfacf05fe588cf13ca/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5a9eb7c-84c49dd-f065827895cb9a08ccfa6514c3f5a916c67a361d/index.html

Web 🕸️
https://95594.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-16T23:49:39Z

🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-16T23:52:44Z

🤖 Help site review: no docs changes required.

This PR is an internal bug fix in the optimistic-data middleware (HandleUnusedOptimisticID.ts and Report/index.ts). It restores an invited participant's login (email) when OpenReport settles a participant that arrived without one, so the account header shows the email correctly again.

It restores expected existing behavior and introduces no new feature, setting, tab, label, or workflow. Nothing in docs/articles documents this optimistic-data handling, and the user-facing chat flow (e.g. Create a New Chat) is unchanged — so no help site article needs updating and no draft docs PR was created.

@mukhrr, please confirm you agree no help site changes are needed here. If you believe an article should be updated, let me know and I'll create the draft PR.

restore invited login when OpenReport settles the participant without…

b1b43ae

… one

melvin-bot Bot assigned mukhrr Jul 8, 2026

mukhrr marked this pull request as ready for review July 9, 2026 02:51

mukhrr requested review from a team as code owners July 9, 2026 02:51

melvin-bot Bot requested review from brunovjk and removed request for a team July 9, 2026 02:51

fixed spell fail

4f380cb

melvin-bot Bot requested review from flaviadefaria and removed request for a team July 9, 2026 02:53

mukhrr added 2 commits July 9, 2026 07:55

added missing Openreport tests

b0e9546

Merge remote-tracking branch 'upstream/main' into fix/92581

2f7ddda

Merge remote-tracking branch 'origin' into fix/92581

be792a8

mukhrr mentioned this pull request Jul 9, 2026

[$250] Chat - Email for new expenpensifail account conversations in account details not shown #92581

Open

7 tasks

brunovjk approved these changes Jul 14, 2026

View reviewed changes

melvin-bot Bot requested a review from inimaga July 14, 2026 19:09

inimaga requested changes Jul 15, 2026

View reviewed changes

respect empty login

e725a88

mukhrr requested a review from inimaga July 16, 2026 00:49

inimaga requested changes Jul 16, 2026

View reviewed changes

restore only when the login key is missing

89eaf61

mukhrr requested a review from inimaga July 16, 2026 11:21

inimaga approved these changes Jul 16, 2026

View reviewed changes

inimaga merged commit 5a9eb7c into Expensify:main Jul 16, 2026
34 checks passed

OSBotify mentioned this pull request Jul 16, 2026

Deploy Checklist: New Expensify 2026-07-16 #96356

Open

52 tasks

Uh oh!

Conversation

mukhrr commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

mukhrr commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented Jul 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 10, 2026

Uh oh!

brunovjk commented Jul 10, 2026

Uh oh!

mukhrr commented Jul 12, 2026

Uh oh!

brunovjk commented Jul 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

inimaga Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

inimaga Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

mukhrr Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

inimaga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mukhrr commented Jul 8, 2026 •

edited

Loading

codecov Bot commented Jul 8, 2026 •

edited by github-actions Bot

Loading

mukhrr commented Jul 9, 2026 •

edited

Loading