Skip to content

[CP staging] Revert "Handle copy policy settings failure in modal with retry option"#96128

Closed
jasperhuangg wants to merge 1 commit into
mainfrom
revert-93710-fedirjh/handle-copy-policy-settings-failure-modal
Closed

[CP staging] Revert "Handle copy policy settings failure in modal with retry option"#96128
jasperhuangg wants to merge 1 commit into
mainfrom
revert-93710-fedirjh/handle-copy-policy-settings-failure-modal

Conversation

@jasperhuangg

Copy link
Copy Markdown
Contributor

Reverts #93710

@jasperhuangg jasperhuangg requested review from a team as code owners July 14, 2026 20:07
@melvin-bot melvin-bot Bot requested review from flaviadefaria and removed request for a team July 14, 2026 20:07
@melvin-bot melvin-bot Bot requested review from mjasikowski and removed request for a team July 14, 2026 20:07
@melvin-bot

melvin-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index 300818e3a89..8d6675e4a65 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -3755,7 +3755,7 @@ ${amount} für ${merchant} – ${date}`,
         facialScan: 'Richtlinie und Einverständniserklärung zur Gesichtserfassung von Onfido',
         onfidoLinks: (onfidoTitle: string) =>
             `<muted-text-micro>${onfidoTitle} <a href='${CONST.ONFIDO_FACIAL_SCAN_POLICY_URL}'>Onfidos Richtlinie und Einverständniserklärung zur Gesichtserkennung</a>, <a href='${CONST.ONFIDO_PRIVACY_POLICY_URL}'>Datenschutz</a> und <a href='${CONST.ONFIDO_TERMS_OF_SERVICE_URL}'>Nutzungsbedingungen</a>.</muted-text-micro>`,
-        tryAgain: 'Erneut versuchen',
+        tryAgain: 'Versuchen Sie es erneut',
         verifyIdentity: 'Identität bestätigen',
         letsVerifyIdentity: 'Lass uns deine Identität bestätigen',
         butFirst: `Aber zuerst das Langweilige. Lies dir im nächsten Schritt den Rechtstext durch und klicke auf „Akzeptieren“, wenn du bereit bist.`,
@@ -5629,7 +5629,7 @@ _Für ausführlichere Anweisungen [besuchen Sie unsere Hilfeseite](${CONST.NETSU
                 feedCouldNotBeLoadedTitle: 'Dieser Feed konnte nicht geladen werden',
                 feedCouldNotBeLoadedMessage:
                     'Beim Laden dieses Feeds ist ein Fehler aufgetreten. Bitte versuche es erneut oder wende dich an deine Administratorin bzw. deinen Administrator.',
-                tryAgain: 'Erneut versuchen',
+                tryAgain: 'Versuchen Sie es erneut',
             },
             addNewCard: {
                 other: 'Sonstiges',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index a7cc398e5dd..3e7ea8c2c9a 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -3626,7 +3626,7 @@ ${amount} para ${merchant} - ${date}`,
         facialScan: 'Política y lanzamiento de la exploración facial de Onfido',
         onfidoLinks: (onfidoTitle: string) =>
             `<muted-text-micro>${onfidoTitle} <a href='${CONST.ONFIDO_FACIAL_SCAN_POLICY_URL}'>Política y lanzamiento de la exploración facial de Onfido</a>, <a href='${CONST.ONFIDO_PRIVACY_POLICY_URL}'>Privacidad</a> y <a href='${CONST.ONFIDO_TERMS_OF_SERVICE_URL}'>Términos de Servicio</a>.</muted-text-micro>`,
-        tryAgain: 'Intentar otra vez',
+        tryAgain: 'Inténtalo de nuevo',
         verifyIdentity: 'Verificar identidad',
         letsVerifyIdentity: '¡Vamos a verificar tu identidad!',
         butFirst: 'Pero primero, lo aburrido. Lee la jerga legal en el siguiente paso y haz clic en "Aceptar" cuando estés listo.',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 4cdb2aefa9a..f2095332ea3 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -3710,7 +3710,7 @@ ${integrationName === CONST.ONBOARDING_ACCOUNTING_MAPPING.other ? 'あなたの'
         facialScan: 'Onfido 顔認証ポリシーおよび同意書',
         onfidoLinks: (onfidoTitle: string) =>
             `<muted-text-micro>${onfidoTitle} <a href='${CONST.ONFIDO_FACIAL_SCAN_POLICY_URL}'>Onfidoの顔スキャンポリシーおよび同意</a>、<a href='${CONST.ONFIDO_PRIVACY_POLICY_URL}'>プライバシー</a>、および<a href='${CONST.ONFIDO_TERMS_OF_SERVICE_URL}'>利用規約</a>。</muted-text-micro>`,
-        tryAgain: '再試行',
+        tryAgain: '再試行してください',
         verifyIdentity: '本人確認',
         letsVerifyIdentity: '本人確認を行いましょう',
         butFirst: `その前に、ちょっと退屈な話です。次のステップで法律関連の内容をよく読んで、準備ができたら「同意」をクリックしてください。`,
@@ -5550,7 +5550,7 @@ _詳しい手順については、[ヘルプサイトをご覧ください](${CO
                 workspaceFeedsCouldNotBeLoadedMessage: 'ワークスペースカードフィードの読み込み中にエラーが発生しました。もう一度お試しいただくか、管理者にお問い合わせください。',
                 feedCouldNotBeLoadedTitle: 'このフィードを読み込めませんでした',
                 feedCouldNotBeLoadedMessage: 'このフィードの読み込み中にエラーが発生しました。もう一度お試しいただくか、管理者にお問い合わせください。',
-                tryAgain: '再試行',
+                tryAgain: '再試行してください',
             },
             addNewCard: {
                 other: 'その他',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c1b1dae9197..29a5cd4fd04 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -3729,7 +3729,7 @@ ${amount} para ${merchant} - ${date}`,
         facialScan: 'Política e Autorização de Varredura Facial da Onfido',
         onfidoLinks: (onfidoTitle: string) =>
             `<muted-text-micro>${onfidoTitle} <a href='${CONST.ONFIDO_FACIAL_SCAN_POLICY_URL}'>Política e Autorização de Varredura Facial da Onfido</a>, <a href='${CONST.ONFIDO_PRIVACY_POLICY_URL}'>Privacidade</a> e <a href='${CONST.ONFIDO_TERMS_OF_SERVICE_URL}'>Termos de Serviço</a>.</muted-text-micro>`,
-        tryAgain: 'Tentar novamente',
+        tryAgain: 'Tente novamente',
         verifyIdentity: 'Verificar identidade',
         letsVerifyIdentity: 'Vamos verificar sua identidade',
         butFirst: `Mas primeiro, a parte chata. Leia o juridiquês na próxima etapa e clique em “Aceitar” quando estiver pronto.`,
@@ -5591,7 +5591,7 @@ _Para instruções mais detalhadas, [visite nossa central de ajuda](${CONST.NETS
                 workspaceFeedsCouldNotBeLoadedMessage: 'Ocorreu um erro ao carregar os feeds de cartões do workspace. Tente novamente ou contate o seu administrador.',
                 feedCouldNotBeLoadedTitle: 'Não foi possível carregar este feed',
                 feedCouldNotBeLoadedMessage: 'Ocorreu um erro ao carregar este feed. Tente novamente ou entre em contato com seu administrador.',
-                tryAgain: 'Tentar novamente',
+                tryAgain: 'Tente novamente',
             },
             addNewCard: {
                 other: 'Outro',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@github-actions

Copy link
Copy Markdown
Contributor

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...onents/Tables/WorkspaceCompanyCardsTable/index.tsx 63.28% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...PolicySettings/CopyPolicySettingsProgressModal.tsx 100.00% <100.00%> (ø)
.../pages/EnablePayments/Pay/Onfido/OnfidoPrivacy.tsx 0.00% <0.00%> (ø)
...ePayments/Wallet/VerifyIdentity/VerifyIdentity.tsx 0.00% <0.00%> (ø)
src/libs/actions/Policy/CopyPolicySettings.ts 77.41% <0.00%> (ø)
... and 12 files with indirect coverage changes

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96128.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://96128.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@jasperhuangg jasperhuangg changed the title Revert "Handle copy policy settings failure in modal with retry option" [CP staging] Revert "Handle copy policy settings failure in modal with retry option" Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants