Update contributing guidelines Docs to require responding to ai reviews - #97361
Update contributing guidelines Docs to require responding to ai reviews#97361FitseTLT wants to merge 3 commits into
Conversation
New contributors routinely leave Codex Review comments unanswered. The rule existed only in PR_AUTHOR_REVIEWER_BEST_PRACTICES.md, and the AI reviewer philosophy doc undercut it by framing all its guidance as "not strict requirements". State the requirement in CONTRIBUTING.md where new contributors read the PR steps, and carve it out as the one strict requirement in AI-REVIEWER.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Docs alone rely on reviewers noticing. A checkbox makes the requirement part of the gate every author already walks through. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I'm 👍. There's a bit of repetition between the two but, since there in different parts of the doc and we want people to respond, I'm cool with it.
and
|
Explanation of Change
New contributors routinely leave AI reviewer (Codex Review) comments unanswered, and the guidelines don't stop it. The requirement was written down in only one place —
PR_AUTHOR_REVIEWER_BEST_PRACTICES.md— which is a secondary doc most first-time contributors never open, and the AI Reviewer philosophy doc actively undercut it by opening its guiding principles with "These are recommendations for working effectively with AI reviewers, not strict requirements."This states the requirement in
CONTRIBUTING.mdas a numbered step in the "Submit your pull request for final review" list that new contributors actually walk through, carves it out inAI-REVIEWER.mdas the one strict requirement among the guiding principles. The rule is that applying AI feedback stays optional but responding to each comment with 👍/👎 and a short explanation is required, so reviewers can tell a considered dismissal from an overlooked comment.Fixed Issues
$ N/A — process/documentation change requested by @mallenexpensify , no linked issue
PROPOSAL: N/A
Tests
N/A — documentation-only change, no app behavior is affected.
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.