Skip to content

Update contributing guidelines Docs to require responding to ai reviews #97361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FitseTLT wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update contributing guidelines Docs to require responding to ai reviews #97361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e604a42
Require contributors to respond to all AI reviewer comments
FitseTLT Jul 29, 2026
17ac470
Add AI reviewer response item to the PR Author Checklist
FitseTLT Jul 29, 2026
78c8db3
remove pull request template changees
FitseTLT Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions contributingGuides/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,16 @@ This helps future investigators understand the history and current status of err
17. Upon submission of a PR, please include a numbered list of explicit testing steps for each platform (Web, iOS, Android, and Mobile Web) to confirm the fix works as expected and there are no regressions.
18. Please add a screenshot of the app running on each platform (Web, iOS, Android, Mobile Web).
19. Please review the [PR Authoring & Reviewing Best Practices](./PR_AUTHOR_REVIEWER_BEST_PRACTICES.md) for standards on PR titles, testing responsibilities, and the review workflow.
20. You must respond to **every** comment left by our AI reviewers (e.g. Codex Review) before your PR is considered ready for review. React with 👍 if you are applying the feedback or 👎 if you are not, and leave a short comment explaining your reasoning either way. You are not required to make every change an AI reviewer suggests — its feedback is advisory — but you are required to respond to each comment so that reviewers can see it was considered rather than overlooked. See the [AI Reviewer philosophy](./philosophies/AI-REVIEWER.md) for more detail.

### Completing the final checklist
20. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued.
21. The items requiring your completion consist of:
21. Once your PR has been deployed to production, a checklist will automatically be commented in the GH issue. You're required to complete the steps that have your name mentioned before payment will be issued.
22. The items requiring your completion consist of:
1. Proposing steps to take for a regression test to ensure the bug doesn't occur again (For information on how to successfully complete this, head [here](https://github.com/Expensify/App/blob/main/contributingGuides/REGRESSION_TEST_BEST_PRACTICES.md)).
2. Identifying and noting the offending PR that caused the bug (if any).
3. Commenting on the offending PR to note the bug it caused and why (if applicable).
4. Starting a conversation on if any additional steps should be taken to prevent further bugs similar to the one fixed from occurring again.
22. Once the above items have been successfully completed, then payments will begin to be issued.
23. Once the above items have been successfully completed, then payments will begin to be issued.

### Timeline expectations and asking for help along the way
- If you have made a change to your pull request and are ready for another review, leave a comment that says "Updated" on the pull request itself.
Expand Down
5 changes: 4 additions & 1 deletion contributingGuides/philosophies/AI-REVIEWER.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ As the codebase and contributor base grow, AI reviewers help maintain consistent

## Guiding Principles

These are recommendations for working effectively with AI reviewers, not strict requirements.
These are recommendations for working effectively with AI reviewers, not strict requirements — with one exception: responding to AI reviewer comments is required, as described below.

### Always respond to AI reviewer comments
PR authors must respond to every comment left by an AI reviewer before requesting final review. React with 👍 when applying the feedback or 👎 when not, and leave a short comment explaining the reasoning either way. Acting on the feedback is optional; responding to it is not. Silence leaves human reviewers unable to tell whether a point was considered and dismissed or simply missed, which is the most common gap we see in PRs from new contributors.

### Treat AI feedback as suggestions
AI reviewers provide automated feedback to assist human reviewers, but their output is not infallible. Contributors and reviewers should evaluate each piece of feedback on its merits rather than blindly accepting or rejecting it.
Expand Down
Loading