Adds a 'State' section with lists of materials#113
Merged
martinjrobins merged 8 commits intoOct 13, 2025
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage ? 96.56%
=======================================
Files ? 9
Lines ? 408
Branches ? 37
=======================================
Hits ? 394
Misses ? 7
Partials ? 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This also adds the required parameters for #60, but doesn't implement the modification of other parameters mentioned. |
Collaborator
Author
|
Note - in the V1.0 PDF, both Initial & Ambient temperature are still listed in the Cell portion of Table 1 as well as in Table 2, I assume that's a bug. |
rtimms
approved these changes
Oct 6, 2025
Collaborator
rtimms
left a comment
There was a problem hiding this comment.
thanks @pipliggins !
@ejfdickinson we will need to update the BPX spec document to reflect these changes
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Fixes #89
Adds a 'State' section to the schema as per BPX 1.0. All
Initial conditions&Thermal stateparams are required, whileDegradationis optional.Parameters described in the current BPX schema as 'colon separated' are implemented as follows:
following discussions in #112.
Errors are raised directing users to the new
Statesection where existing parameters have been moved.I haven't made any currently optional parameters required (see #89 (comment)) as I'm not entirely clear which should be changed.