Add wimprates rate generator to nestWIMPSource #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzomag
force-pushed
the
RJ-XLZD_simple
branch
from
b6a3540 to
52e9ed3
Compare
Collaborator
Author
|
I fixed |
…flamedisx into RJ-XLZD_simple"" This reverts commit 65da548.
Closed
Scaling was only applied when modulation off
robertsjames
requested changes
Aug 14, 2024
The energy histogram is not normalised in the time dimension. Robert's expalation: I think all you need to do is remove scale = time_bin_width / nu.year # Convert from [per year] to [per time_bin_width] Whilst in principle keeping this and removing / self.n_time_bins would solve things at the level of source.mu_before_efficiencies(), it will mess up the tensor-based calculation of the differential rate, as the thing that is queried should be the spectrum corresponding to a given event time (such that the sum of the spectrum gives the expected counts within that energy range, after scaling by the exposure)
…flamedisx into RJ-XLZD_simple"" This reverts commit 65da548.
Scaling was only applied when modulation off
The energy histogram is not normalised in the time dimension. Robert's expalation: I think all you need to do is remove scale = time_bin_width / nu.year # Convert from [per year] to [per time_bin_width] Whilst in principle keeping this and removing / self.n_time_bins would solve things at the level of source.mu_before_efficiencies(), it will mess up the tensor-based calculation of the differential rate, as the thing that is queried should be the spectrum corresponding to a given event time (such that the sum of the spectrum gives the expected counts within that energy range, after scaling by the exposure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to utilise the
wimpratespackage to compute the differential rates of WIMP-nucleus interaction instead of fetching them from pickle files.If
modulation==True, the differential rate (with respect to energy and time, per unit mass) will take into consideration annual modulation patterns, calculated within wimprates itself.Initial and final timestamps are provided by the user using keyword arguments to the class initialiser method.
The livetime is computed from their difference.
If
modulation==False, a conservative timestamp is chosen by wimprates to obtain the average annual rate. The differential rate will then be calculated once, and the result repeated into an array.This option is more time efficient.
A multiprocessing implementation of the former case should be implemented.
Currently, there is a discrepancy in the output rate by the function wrt the pickled file's energy spectrum by a factor of 10 approximately!
This needs to be investigated