Add a team link component to simplify routing #4942
Conversation
…nent-to-simplify-routing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4942 +/- ##
=======================================
Coverage 78.40% 78.40%
=======================================
Files 329 329
Lines 15501 15501
Branches 3582 3582
=======================================
Hits 12154 12154
Misses 3347 3347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…-simplify-routing
|
@cstns is this ready for review? Noticed you've assigned no reviewer...? |
|
Need a couple of moments to refresh my memory |
|
#4891 would need to be merged in first so we can keep it simple, and I'd need to sort some conflicts on that one first. I'll mark it as a draft untill then |
…-simplify-routing # Conflicts: # frontend/src/components/DevicesBrowser.vue # frontend/src/pages/device/index.vue
| extendedProps () { | ||
| const props = { ...this.$props } | ||
| if (!props.to.params.team_slug) { | ||
| props.to.params.team_slug = this.team.slug |
There was a problem hiding this comment.
and in a circumstance where this.team is undefined? I appreciate our use case here is for when we do have a team, but new users wont' have a this.team, so technically we should handle this scenario?
There was a problem hiding this comment.
that is a valid point, will have to go through the sign-up procedure and check but from the top of my head users shouldn't encounter team-links only after being assigned to a team and have the full ui at their disposal.
I'll have a look over it later after this current release when i'll have some spare time on my hands, this is not an important task
Description
Adds a ff-team-link component that would simplify routes parametrization
Related Issue(s)
part of #4836
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel