-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a team link component to simplify routing #4942
Open
cstns
wants to merge
6
commits into
main
Choose a base branch
from
add-a-team-link-component-to-simplify-routing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−13
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1940af5
Add a new TeamLink component and replace existing routes
cstns 5597511
Merge remote-tracking branch 'origin/main' into add-a-team-link-compo…
cstns 1622f35
Merge branch 'app-routes-follow-up' into add-a-team-link-component-to…
cstns 76aef48
Merge branch 'app-routes-follow-up' into add-a-team-link-component-to…
cstns 9d04ad9
add a fallback to the back button in case there's no team loaded
cstns 4e8961f
Merge branch 'main' into add-a-team-link-component-to-simplify-routing
cstns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
<template> | ||
<router-link | ||
v-slot="{ href, navigate }" | ||
v-bind="extendedProps" | ||
custom | ||
> | ||
<a | ||
v-bind="$attrs" | ||
:href="href" | ||
@click="navigate" | ||
> | ||
<slot /> | ||
</a> | ||
</router-link> | ||
</template> | ||
|
||
<script> | ||
import { RouterLink as DefaultRouterLink } from 'vue-router' | ||
import { mapState } from 'vuex' | ||
|
||
export default { | ||
name: 'TeamLink', | ||
inheritAttrs: false, | ||
props: { | ||
...DefaultRouterLink.props | ||
}, | ||
computed: { | ||
...mapState('account', ['team']), | ||
extendedProps () { | ||
const props = { ...this.$props } | ||
if (!props.to.params.team_slug) { | ||
props.to.params.team_slug = this.team.slug | ||
} | ||
return props | ||
} | ||
} | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and in a circumstance where
this.team
isundefined
? I appreciate our use case here is for when we do have a team, but new users wont' have athis.team
, so technically we should handle this scenario?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is a valid point, will have to go through the sign-up procedure and check but from the top of my head users shouldn't encounter team-links only after being assigned to a team and have the full ui at their disposal.
I'll have a look over it later after this current release when i'll have some spare time on my hands, this is not an important task