Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Topics Schema Storage #5053

Open
wants to merge 88 commits into
base: 3rd-party-broker
Choose a base branch
from

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jan 24, 2025

Description

  • /api/v1/teams/:teamId/brokers/:brokerId/topics
    • GET returns all topics and meta data for a given broker
    • POST adds a new topic to a broker
  • /api/v1/teams/:teamId/brokers/:brokerId/topics/:topicId
    • PUT updates metadata for a give topic
    • DELETE deletes a topic and it's metadata

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 82.20859% with 29 lines in your changes missing coverage. Please review.

Project coverage is 78.49%. Comparing base (ca8099c) to head (bafc741).

Files with missing lines Patch % Lines
forge/ee/routes/teamBroker/3rdPartyBroker.js 79.76% 17 Missing ⚠️
forge/db/models/MQTTTopicSchema.js 88.57% 4 Missing ⚠️
forge/ee/routes/teamBroker/schema.js 0.00% 3 Missing ⚠️
forge/containers/stub/index.js 50.00% 1 Missing ⚠️
forge/containers/wrapper.js 75.00% 1 Missing ⚠️
...migrations/20250124-01-EE-add-mqtt-topic-schema.js 83.33% 1 Missing ⚠️
...migrations/20250203-01-EE-add-team-broker-creds.js 85.71% 1 Missing ⚠️
...db/migrations/20250205-01-EE-add-payload-schema.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           3rd-party-broker    #5053      +/-   ##
====================================================
+ Coverage             78.19%   78.49%   +0.29%     
====================================================
  Files                   333      337       +4     
  Lines                 15668    15772     +104     
  Branches               3610     3634      +24     
====================================================
+ Hits                  12252    12380     +128     
+ Misses                 3416     3392      -24     
Flag Coverage Δ
backend 78.49% <82.20%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb marked this pull request as ready for review February 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants