feat: Adding signal and external error detection & output #3856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger get cut by other ranks
…rnal errors + adding docs
…o feature/rey/signal-and-external-error-managment
…ate-yaml-file-and-structure' into feature/rey/signal-and-external-error-managment
…o feature/rey/signal-and-external-error-managment
…o feature/rey/signal-and-external-error-managment
…o feature/rey/signal-and-external-error-managment
…file-and-structure-2' into feature/rey/signal-and-external-error-managment
…file-and-structure-2' into feature/rey/signal-and-external-error-managment
…external-error-managment' into feature/rey/signal-and-external-error-managment-2
MelReyCG
requested review from
corbett5,
cssherman,
paveltomin,
rrsettgast and
wrtobin
as code owners
MelReyCG
added
ci: run CUDA builds
…nto feature/rey/signal-and-external-error-managment-2
…file-and-structure-2' into feature/rey/signal-and-external-error-managment-2
…file-and-structure-2' into feature/rey/signal-and-external-error-managment-2
|
Can you give some output example in the description of your PR please |
arng40
reviewed
Oct 20, 2025
| GEOS_WARNING( "Failed to duplicate original descriptor: " + std::string( strerror( errno ) ) ); | ||
| } | ||
|
|
||
| // Redirect stderr to pipe |
There was a problem hiding this comment.
Suggested change
| // Redirect stderr to pipe | |
| // make the deviation pipe point to what the original pipe point |
| GEOS_WARNING( "Failed to redirect stream: " + std::string( strerror( errno ) ) ); | ||
| } | ||
|
|
||
| // Close the write end of the parent pipe (we write through stderr now) |
There was a problem hiding this comment.
Suggested change
| // Close the write end of the parent pipe (we write through stderr now) | |
| // Close the writeEnd of the deviation pipe since the original pipe point to it | |
| we can now read through the pipe |
| m_unprocessedData.reserve( 16384 ); | ||
|
|
||
| #ifdef __linux__ | ||
| ::fcntl( m_deviationPipe.readEnd(), F_SETPIPE_SZ, 1048576 ); |
There was a problem hiding this comment.
Suggested change
| ::fcntl( m_deviationPipe.readEnd(), F_SETPIPE_SZ, 1048576 ); | |
| maybe add a comment for this line |
| return instance; | ||
| } | ||
|
|
||
| void ExternalErrorHandler::enableStderrPipe( bool enable ) |
There was a problem hiding this comment.
enableStderrPipeDeviation ?
…nto feature/rey/signal-and-external-error-managment-2
…nto feature/rey/signal-and-external-error-managment-2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on Amandine work on adding error YAML file in GEOS (PR #3828), and aims at adding a detection & management inside GEOS of 1. Error signals, 2. External errors from dependencies, in order to be able to manage & output them in the log & error YAML file.
Managing those external errors gives us the opportunity to:
This PR also prevent the stacktrace to be cut by other ranks message, which could previously happen on a signal.
We can imagine adding later some tag for each dependency (system, LvArray, Hypre, ...) to quickly identify / filter issues source.
(Replaces #3722)