fix: correct the effective stress calculation for thermoporomechanics #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfeifan
requested review from
CusiniM,
Guotong-Ren,
castelletto1,
jhuang2601 and
rrsettgast
as code owners
frankfeifan
added
flag: requires rebaseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to correct the current GEOS effective stress calculation such that it is consistent with Terzaghi definition. Detailed explanations on the issue and this change can be seen in the file attached.
THMEffStress_GEOS.pdf
dTotalStress_dTemperatureinPorousSolidfor the thermal caseplasticStrainfield to constitutive model