feat: CI - Add code rules checking action #3914
Open
+706
−376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arng40
added
type: CI
arng40
requested review from
MelReyCG,
corbett5,
dkachuma,
matteofrigo5 and
victorapm
as code owners
…EV/GEOS into feat/dudes/add-code-rules
MelReyCG
changed the title
MelReyCG
changed the title
MelReyCG
changed the title
MelReyCG
requested changes
Nov 27, 2025
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
I think you showed that script works, but it seems that there are some critical issues in it.
Comment on lines
+177
to
+184
| # - name: Ubuntu debug (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces | ||
| # CMAKE_BUILD_TYPE: Debug | ||
| # DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10 | ||
| # BUILD_SHARED_LIBS: ON | ||
| # ENABLE_HYPRE: OFF | ||
| # ENABLE_TRILINOS: ON | ||
| # GEOS_ENABLE_BOUNDS_CHECK: ON | ||
| # HOST_CONFIG: /spack-generated.cmake |
Contributor
There was a problem hiding this comment.
you cannot leave CI modifs aimed for test and request review.
Comment on lines
+130
to
+131
| # - name: Check code rules | ||
| # BUILD_AND_TEST_ARGS: --test-code-rules |
| FULL_FILE_PATTERN="${FILE_PREFIX}${FILE_PATTERNS[*]}" | ||
| # Build the find command | ||
| FIND_CMD="find" | ||
| FIND_FILE_CMD="$FIND_CMD $FILE_PATH_PATERN"' \( -name "*.hpp" -o -name "*.cpp" \)' |
Contributor
There was a problem hiding this comment.
FILE_PATH_PATTERN seems never initialized.
| FILES=$(eval "$FIND_FILE_CMD" 2>/dev/null); | ||
|
|
||
| # Main loop | ||
| for file in $FILES; do |
Contributor
There was a problem hiding this comment.
How does it behave with spaces in folder / file names?
| ARRAY_UMAP=() | ||
| ARRAY_VECTOR=() | ||
|
|
||
| FULL_FILE_PATTERN="${FILE_PREFIX}${FILE_PATTERNS[*]}" |
Contributor
There was a problem hiding this comment.
I'm not sure to get that right, but does it result to the following?
src/coreComponents/codingUtilities/* common/* dataRepository/* ...
If yes, how can it work as the file prefix is not added to each file pattern? maybe it would be easier with a cd FILE_PREFIX (rename to VALIDATING_FOLDER?)
Comment on lines
+107
to
+109
| print_violation "$MAP_VIOLATIONS_FOUND" ARRAY_MAP "std::map" | ||
| print_violation "$UMAP_VIOLATIONS_FOUND" ARRAY_UMAP "std::unordered_map" | ||
| print_violation "$VECTOR_VIOLATIONS_FOUND" ARRAY_VECTOR "std::vector" |
Contributor
There was a problem hiding this comment.
- Add an array for them,
- did you missed
std::array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aim to create a new CI Target in order to ensure the use of the internal tool in geos and to promote the best coding practice.
First, this PR set up the CI
check_code_rulesand will ensure the use of :stdMap,stdUnorderedMap&stdVectorThis PR will be merged after :