Skip to content

Commit

Permalink
[DO-NOT-MERGE] Relaxed PyTorch lightning requirements (#7)
Browse files Browse the repository at this point in the history
* Update setup.cfg

Relax PyTorch lightning requirements

* Update setup.cfg

* type ignore

* Update tests.yaml

---------

Co-authored-by: Irina Espejo Morales <[email protected]>
Co-authored-by: Dimitrios Christofidellis <[email protected]>
3 people authored Dec 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent dcaecbc commit ef538a9
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10"]
python-version: ["3.8", "3.9", "3.10"]

steps:
- uses: actions/checkout@v3
@@ -46,4 +46,4 @@ jobs:
- name: Test entry-points
run: |
gt4sd-trainer-hf-pl --help
gt4sd-pl-to-hf --help
gt4sd-pl-to-hf --help
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ install_requires =
importlib-resources>=5.10.0
joblib>=1.1.0
numpy>=1.16.5
pytorch_lightning<=1.9.5
lightning>=2.0.0
pyyaml>=5.4.1
regex>=2.5.91
scikit-learn>=1.0.0
4 changes: 1 addition & 3 deletions src/gt4sd_trainer/hf_pl/models/core.py
Original file line number Diff line number Diff line change
@@ -74,9 +74,7 @@ def forward(self, x: Tensor) -> Tensor: # type: ignore
"""
return self.model(x).logits # type:ignore

def configure_optimizers(
self,
) -> Dict[str, object]:
def configure_optimizers(self) -> Dict[str, object]: # type:ignore
"""Create and return the optimizer.
Returns:
output (dict of str: Any):

0 comments on commit ef538a9

Please sign in to comment.