[DO-NOT-MERGE] Relaxed PyTorch lightning requirements #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax PyTorch lightning requirements
drugilsberg
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO-NOT-MERGE]
Changed to
pytorch-lightning >= 2.0.0.In a previous issue #3 and PR #4 it was raised the issue of incompatibility between
1.9.5and>=1.9.5in gt2sd-trainer-hf-pl.The Lightning Team has released this guide to update version. I have searched for more incompatibilities mentioned in the guide and found none.
My local tests pass, I want to trigger a github workflows build with this PR like discussed with Matteo.
I have checked public repos dependent of this one with the pl requirement relax and it runs fine.