chore: replace docker-compose with nix process-compose for dev deps#140
Draft
vindard wants to merge 1 commit into
Draft
chore: replace docker-compose with nix process-compose for dev deps#140vindard wants to merge 1 commit into
vindard wants to merge 1 commit into
Conversation
Align with lana-bank's docker-free dev tooling: contributors no longer need Docker (or podman) installed. start-deps now runs Postgres directly via process-compose-flake, with data stored under .nix-deps/. Drops docker-compose.yml and nix/podman-runner.nix. CI surfaces (.github workflows + Concourse pipeline) are unchanged — both already invoke nix run .#nextest, whose internals now use the process-compose path. Refs GaloyMoney/volcano-wip#772.
This was referenced May 27, 2026
6 tasks
| bacon | ||
| postgresql | ||
| docker-compose | ||
| ytt |
There was a problem hiding this comment.
I think we still need ytt in the dev shell. ci/repipe still uses ytt, but after this change nix develop no longer includes the tool needed to update the Concourse pipeline
| setup-db = { | ||
| command = "${setupDbDev}/bin/setup-db-dev"; | ||
| depends_on.core-pg.condition = "process_healthy"; | ||
| availability.exit_on_end = false; |
There was a problem hiding this comment.
I think this makes DB migrations racy. This makes setup-db behave like a background process (i.e. not blocking until it is done), so project is-ready --wait may return once migrations have started rather than after they have finished. Then tests can start before the fresh DB schema is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns es-entity's dev tooling with lana-bank's docker-free pattern: contributors no longer need Docker (or podman) installed locally.
start-depsnow runs Postgres directly viaprocess-compose-flake, with data stored under.nix-deps/.process-compose-flakeflake inputnix-deps-base(process-compose stack:core-pg+setup-db) andsetup-db-devpackagesnextest-runnerto use the new stack instead ofpodman-compose-runnerdocker-compose.ymlandnix/podman-runner.nixdocker-compose,podman,podman-composefromnativeBuildInputsMakefilestart-deps/clean-deps/setup-dbto callnix run .#...CI is unchanged: both
.github/workflows/test.ymlandci/pipeline.ymlalready invokenix run .#nextest, and the runner's internals are what we updated.Refs
Test plan
make start-depsbrings up Postgres + auto-applies migrations under.nix-deps/core-pg/cargo nextest run --workspace— all 171 tests pass against the new PGcargo sqlx prepare --workspace --checksucceedsmake clean-depsstops the stack and clears.nix-deps/🤖 Generated with Claude Code