hotel id header injection - MERGE AFTER ONBOARDING/CLERK ORGS#287
Merged
manueltorres0 merged 6 commits intomainfrom Apr 7, 2026
Merged
hotel id header injection - MERGE AFTER ONBOARDING/CLERK ORGS#287manueltorres0 merged 6 commits intomainfrom
manueltorres0 merged 6 commits intomainfrom
Conversation
manueltorres0
changed the title
manueltorres0
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
========================================
+ Coverage 0.62% 1.88% +1.26%
========================================
Files 78 86 +8
Lines 3218 3289 +71
Branches 0 24 +24
========================================
+ Hits 20 62 +42
- Misses 3198 3227 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Dao-Ho
requested changes
Apr 7, 2026
clients/web/src/routes/__root.tsx
Outdated
| function AppConfigurator() { | ||
| const { getToken } = useAuth(); | ||
| const { organization } = useOrganization(); | ||
| const hotelId = organization?.publicMetadata.hotel_id as string; |
clients/mobile/app/_layout.tsx
Outdated
| function AppConfigurator() { | ||
| const { getToken } = useAuth(); | ||
| const { organization } = useOrganization(); | ||
| const hotelId = organization?.publicMetadata?.hotel_id as string; |
Contributor
There was a problem hiding this comment.
feels like this shouldn't need a typecast. Assuming that casting is used here for empty case (user isn't part of an org), I'd actually redirect them to a separate page letting them know instead of casting into an empty string as it'll cause some downstream errors that aren't accurate to what the problem is
Dao-Ho
added a commit
that referenced
this pull request
Apr 7, 2026
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issue(s)
Closes #241
What Changed?
Testing & Validation
How this was tested
Notes & Nuances
Pre-Merge Checklist
Code Quality
Testing & CI
Documentation
Reviewer Notes