-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Add PyGMT logo to README & docs #3845
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening the PR so that we can better preview what the logo looks like on the web or PDF. Just want to note that the logo is not finalized yet, and we may tweak the logo based on the community responses. |
@michaelgrund Please help replace the favicon |
Not sure if it works with direct URL references like I did. |
It seems not working. Could you please add the static images to the repository instead? The PyGMT banner on the landing page also needs to be updated Lines 4 to 10 in eb0ebe7
|
Co-authored-by: Dongdong Tian <[email protected]>
FYI, currently the original images stored in @sfrooti's repo are saved in our |
Co-authored-by: Dongdong Tian <[email protected]>
@michaelgrund I've pushed a commit to this branch to display the logo in the sidebar. Now the landing page looks like below: The logo in the sidebar will look better if the background is transparent. |
@@ -30,27 +30,6 @@ | |||
{% endif %} | |||
{% endblock %} | |||
|
|||
|
|||
{% block sidebartitle %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, the above link is the default template for the sidebartitle block in the sphinx_rtd_theme.
Removing the custom sidebartitle
block may make the version selector disappear (#3542), so we need to update this block instead of removing it.
Great thanks! |
Description of proposed changes
Since we now have a logo (#1404) we should think about in which format we want to place it in our README/docs. I would suggest to use the horizontal one. Would also suggest to add the subtitle A Python interface for the Generic Mapping Tools. Maybe @sfrooti may add that to the prepared logos. Also need to increase the resolution. Finally, the yellow lines do not really stand out from the background.
Previews:
https://pygmt-dev--3845.org.readthedocs.build/en/3845/
Landig page
Favicon (tab icon)
GitHub README
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code