-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Code PyGMT logo in PyGMT #3849
base: main
Are you sure you want to change the base?
Conversation
/format |
I feel the logo definition should be separated into a standalone method, similar to the method to plot the GMT logo. This would allow to plot the PyGMT logo by calling something like |
ruff v0.10.0 was released 2 hours ago causing the newly falling code style checks. |
Co-authored-by: Wei Ji <[email protected]>
pygmt/src/pygmtlogo.py
Outdated
# Start of subfunction | ||
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
def create_logo( # noqa: PLR0915 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to move create_logo
outside of the pygmtlogo
function.
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
pygmt/src/pygmtlogo.py
Outdated
# ----------------------------------------------------------------------------- | ||
# Define wordmark | ||
# ----------------------------------------------------------------------------- | ||
font = "AvantGarde-Book" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The font Space Grotesk by Florian Karsten is not available in GMT. Currently the font AvantGarde-Book is used.
Description of proposed changes
Related to #1404 (comment), create the PyGMT logo in Python with PyGMT.
Figure.pygmtlogo
orFigure.logo_pygmt
as part of theFigure
class or addition to the methodFigure.logo
(which plots the GMT logo)Preview:
Related to
TODO:
shape="circle" | "hexagon"
orhex=False | True
Figure.image
)Figure
class or addition toFigure.logo
.Issues:
Figure
objects using the saved eps files. Maybe this is not easy to handle when converting to a method of theFigure
classe.Version at commit 39e5ba1:
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code