-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Rename Gallery example for GMT logo #3856
Conversation
Actually, I'm debating if we should combine the pygmtlogo function into the |
I am also fine with having a combined method for both logos! In this case we will probably have a combined gallery example showing both logos. I think it make sense to focus in PR #3849 on the code of the extend or new method. For the case of a combined method, we can maybe use this PR to extend the current gallery example? For now, I set this PR to draft. A bit off topic: In the gallery example for |
Yes, we just need to find another image and replace the GMT one. |
Actually, even if we decide to combine the pygmt logo into the |
Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
In case we have a separate gallery example for the PyGMT logo in the future, I feel it makes sense to rename the already existing gallery example for the GMT logo and adjust the title to be more specific.
Also rewrap to the maximum allowed line length, which seems to be extended in the last ruff release, and is now 88 characters.
Preview:
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash command is:
/format
: automatically format and lint the code