Skip to content

Generalize SetMatcher to support Document Model#288

Merged
IsmailMehdi merged 9 commits intoGoogleCloudPlatform:mainfrom
pl04351820:fixed-match-scores
Mar 24, 2026
Merged

Generalize SetMatcher to support Document Model#288
IsmailMehdi merged 9 commits intoGoogleCloudPlatform:mainfrom
pl04351820:fixed-match-scores

Conversation

@pl04351820
Copy link
Copy Markdown
Contributor

@pl04351820 pl04351820 commented Mar 24, 2026

For golden result [{"total_orders": {"int": 15}}] . Current Firestore runs returns following errors:

"unhashable type: 'dict'". 
  • The PR adds Auto-detected based on nested structures and uses Counter/Multiset comparisons (respects duplicate counts).
  • For Classic SQL: Keep it backward compatible (Set semantics, ignores column names).
  • Tests: Added test cases in evalbench/test/set_matcher_test.py covering match cases.

@pl04351820 pl04351820 requested a review from IsmailMehdi as a code owner March 24, 2026 05:14
@IsmailMehdi
Copy link
Copy Markdown
Collaborator

/gcbrun

@IsmailMehdi IsmailMehdi merged commit 5c00f23 into GoogleCloudPlatform:main Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants