Skip to content

refactor(ai-elements): migrate live event cards#527

Merged
HomenShum merged 3 commits into
mainfrom
codex/ai-elements-live-event-card
Jul 14, 2026
Merged

refactor(ai-elements): migrate live event cards#527
HomenShum merged 3 commits into
mainfrom
codex/ai-elements-live-event-card

Conversation

@HomenShum

Copy link
Copy Markdown
Owner

What changed

  • Migrates FastAgentPanel live tool activity onto the shared AI Elements Tool primitive.
  • Adds a single typed projection from unified and legacy event streams with stable semantic IDs and deterministic collision suffixes.
  • Preserves honest Pending/Running/Completed/Error/Denied states, including output-denied and lagging nonempty errorText precedence.
  • Fails closed for unknown future unified states instead of falsely presenting them as running.
  • Adds an accessible compact-sidebar Live Events opener on the canonical Cockpit path without duplicating the global overlay or streaming hook.
  • Adds focused projection, card, denied/error, ID-stability, collision, and header reachability coverage.

Why

The previous custom card could not safely adopt the primitive while unified event states, legacy events, and compact sidebar reachability were mixed in the parent. Two rounds of independent review found and then verified fixes for stale error state, unstable IDs, lost denial semantics, and an unreachable canonical opener.

Validation

  • Focused Live/Header/Tool/Input/UIMessage contracts: 77 passed
  • Full FastAgentPanel: 203 passed, 19 environment-gated skipped
  • Explicit streaming guard: 1 passed
  • npx tsc --noEmit --pretty false
  • Design system: 11 passed; npm run lint:design has 0 high findings
  • npm run build
  • Bundle guard: FastAgentPanel 1,558,184 B; separate code block 73,341 B; separate Streamdown 163,187 B; 0 Shiki/oniguruma/wasm markers in panel; 0 assets/shiki/ service-worker precache entries; no asset over 10 MiB
  • Independent final P0/P1 audit: GO, no findings

Release

Ready for required checks and CI-gated squash auto-merge. No admin bypass.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodebench-ai Ready Ready Preview, Comment Jul 14, 2026 12:30pm

Request Review

@github-actions

Copy link
Copy Markdown

PR size advisory

This PR adds 1113 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC.

If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:

  • splitting into 2-3 PRs along independent concerns
  • pre-discussing the architecture change in a GitHub Discussion before merge

This is advisory — it does not block the merge.

@github-actions

Copy link
Copy Markdown

✅ Dogfood Visual QA Gate: PASSED

Check Status
Screenshots 23 captured (pass)
Walkthrough 9 chapters (pass)
Key Frames 9 extracted (pass)
Scribe Steps 8 how-to steps (pass)
Build success
Artifacts

Download the dogfood-evidence-ed088fd artifact from the Actions tab for full screenshots, frames, and walkthrough video.


Generated by Dogfood QA Gate

@HomenShum HomenShum merged commit 28d704b into main Jul 14, 2026
15 of 17 checks passed
@HomenShum HomenShum deleted the codex/ai-elements-live-event-card branch July 14, 2026 12:34
@github-actions

Copy link
Copy Markdown

Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact (pr-demo-527) at https://github.com/HomenShum/NodeBenchAI/actions/runs/29333031603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants