Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make texture scale changeable by display DPI #1086

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Make texture scale changeable by display DPI #1086

merged 1 commit into from
Nov 2, 2023

Conversation

HollowMan6
Copy link
Collaborator

Resolves #1078

@HollowMan6 HollowMan6 marked this pull request as draft October 23, 2023 20:46
HollowMan6
HollowMan6 commented Oct 23, 2023
View reviewed changes
Copy link
Collaborator Author

@HollowMan6 HollowMan6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed now

@HollowMan6 HollowMan6 marked this pull request as ready for review October 23, 2023 21:38
@felipeerias
Copy link
Collaborator

I've been looking at the relationship between display density and display DPI. For example:

  • density 1, DPI 100

pico scale dpi 1 100

  • density 2, DPI 200

pico scale dpi 2 200

The second option shows the same text at the same size, but it is much clearer and sharper.

I don't know if there is a way to find the right combination of values for each device automatically.

@HollowMan6
Copy link
Collaborator Author

I don't know if there is a way to find the right combination of values for each device automatically.

After we get this PR merged so that changing DPI works, I guess we can of course pre-set the default values of density and dpi for each device by adding a switch case here:

wolvic/app/src/common/shared/com/igalia/wolvic/browser/SettingsStore.java

Line 88 in a003843

public final static float DISPLAY_DENSITY_DEFAULT = 1.0f;

wolvic/app/src/common/shared/com/igalia/wolvic/browser/SettingsStore.java

Line 91 in a003843

public final static int DISPLAY_DPI_DEFAULT = 96;

The current default value looks good to me using Meta Quest 2, and unfortunately, I don't have any other devices. We need to fine-tune those values case-by-case and I suggest we do it in a separate PR.

@felipeerias
Copy link
Collaborator

Yes, I agree that we should do that in a separate PR.

I have opened #1088 to track that investigation.

felipeerias
felipeerias approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@felipeerias felipeerias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeerias felipeerias merged commit a43440e into main Nov 2, 2023
@felipeerias felipeerias deleted the texture-dpi branch November 2, 2023 10:15
HollowMan6 added a commit that referenced this pull request Nov 20, 2023
@HollowMan6
Fix widgets hovering in library UI when DPI is not 100
dc054da 
Actually issue #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

Resolves #1088 together with the reverted reverted commit

Signed-off-by: Songlin Jiang <[email protected]>
@HollowMan6 HollowMan6 mentioned this pull request Nov 20, 2023
Merged
HollowMan6 added a commit that referenced this pull request Nov 21, 2023
@HollowMan6
Fix widgets hovering in library UI when DPI is not 100
bbda638 
The issue mentioned in #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this pull request Nov 21, 2023
@HollowMan6
Fix widgets hovering in library UI when DPI is not 100
eb7151f 
The issue mentioned in #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6 added a commit that referenced this pull request Nov 21, 2023
@HollowMan6 @svillar
Fix widgets hovering in library UI when DPI is not 100 (#1107)
b92ea92 
* Fix widgets hovering in library UI when DPI is not 100

The issue mentioned in #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

---------

Signed-off-by: Songlin Jiang <[email protected]>
Co-authored-by: Sergio Villar Senin <[email protected]>
felipeerias pushed a commit that referenced this pull request Nov 27, 2023
@HollowMan6 @felipeerias
Make texture scale changeable by display DPI (#1086)
939bbc2 
Resolves #1078

Signed-off-by: Songlin Jiang <[email protected]>
felipeerias pushed a commit that referenced this pull request Nov 27, 2023
@HollowMan6 @svillar @felipeerias
Fix widgets hovering in library UI when DPI is not 100 (#1107)
6748df3 
* Fix widgets hovering in library UI when DPI is not 100

The issue mentioned in #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

---------

Signed-off-by: Songlin Jiang <[email protected]>
Co-authored-by: Sergio Villar Senin <[email protected]>
felipeerias pushed a commit that referenced this pull request Dec 7, 2023
@HollowMan6 @felipeerias
Make texture scale changeable by display DPI (#1086)
520a902 
Resolves #1078

Signed-off-by: Songlin Jiang <[email protected]>
felipeerias pushed a commit that referenced this pull request Dec 7, 2023
@HollowMan6 @svillar @felipeerias
Fix widgets hovering in library UI when DPI is not 100 (#1107)
b27b874 
* Fix widgets hovering in library UI when DPI is not 100

The issue mentioned in #1106 is not caused by #1105, but rather
#1086 (comment)

This commit adds an exception to the library UI so that we
make sure we are actually in the web page when we reset the
scale to 1 for motion event handling.

---------

Signed-off-by: Songlin Jiang <[email protected]>
Co-authored-by: Sergio Villar Senin <[email protected]>
@HollowMan6 HollowMan6 mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeerias felipeerias felipeerias approved these changes

@svillar svillar Awaiting requested review from svillar

@javifernandez javifernandez Awaiting requested review from javifernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to improve sharpness at 0.5 window size
2 participants
@HollowMan6 @felipeerias