Skip to content

Remove Deleg.conwayEraSpecificSpec #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
+10 −40
Merged

Remove Deleg.conwayEraSpecificSpec #5267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ conwayEraGenericSpec = do
conwayEraSpecificSpec :: SpecWith (ImpInit (LedgerSpec ConwayEra))
conwayEraSpecificSpec = do
describe "Conway era specific Imp spec" $ do
describe "DELEG" Deleg.conwayEraSpecificSpec
describe "UTXO" Utxo.conwayEraSpecificSpec

instance EraSpecificSpec ConwayEra where
Expand Down
32 changes: 2 additions & 30 deletions eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/DelegSpec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

module Test.Cardano.Ledger.Conway.Imp.DelegSpec (
spec,
conwayEraSpecificSpec,
) where

import Cardano.Ledger.Address (RewardAccount (..))
Expand Down Expand Up @@ -169,13 +168,12 @@ spec = do

describe "Delegate stake" $ do
it "Delegate to unregistered pool" $ do
expectedDeposit <- getsNES $ nesEsL . curPParamsEpochStateL . ppKeyDepositL

cred <- KeyHashObj <$> freshKeyHash
regTxCert <- genRegTxCert cred
submitTx_ $
mkBasicTx mkBasicTxBody
& bodyTxL . certsTxBodyL
.~ [RegDepositTxCert cred expectedDeposit]
.~ [regTxCert]

poolKh <- freshKeyHash
submitFailingTx
Expand Down Expand Up @@ -529,29 +527,3 @@ spec = do
accounts <- getsNES $ nesEsL . esLStateL . lsCertStateL . certDStateL . accountsL
impAnn (show cred <> " expected to not have their vote delegated") $
expectNothingExpr (lookupDRepDelegation cred accounts)

conwayEraSpecificSpec :: SpecWith (ImpInit (LedgerSpec ConwayEra))
conwayEraSpecificSpec = do
describe "Delegate stake" $ do
it "Register and delegate in the same transaction" $ do
cred1 <- KeyHashObj <$> freshKeyHash
regTxCert1 <- genRegTxCert cred1
poolKh <- freshKeyHash
registerPool poolKh
submitTx_ $
mkBasicTx mkBasicTxBody
& bodyTxL . certsTxBodyL
.~ [ regTxCert1
, DelegTxCert cred1 (DelegStake poolKh)
]
expectDelegatedToPool cred1 poolKh

cred2 <- KeyHashObj <$> freshKeyHash
regTxCert2 <- genRegTxCert cred2
submitTx_ $
mkBasicTx mkBasicTxBody
& bodyTxL . certsTxBodyL
.~ [ regTxCert2
, DelegStakeTxCert cred2 poolKh -- using the pattern from Shelley
]
expectDelegatedToPool cred2 poolKh
3 changes: 1 addition & 2 deletions eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,4 @@ shelleyEraSpecificSpec = do
Deleg.shelleyEraSpecificSpec

instance EraSpecificSpec ShelleyEra where
eraSpecificSpec =
describe "DELEG" Deleg.shelleyEraSpecificSpec
eraSpecificSpec = shelleyEraSpecificSpec
14 changes: 7 additions & 7 deletions eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/DelegSpec.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,13 @@ spec = do
it "Register and delegate in the same transaction" $ do
poolKh <- freshKeyHash
registerPool poolKh
freshKeyHash >>= \kh -> do
regTxCert <- genRegTxCert (KeyHashObj kh)
submitTx_ $
mkBasicTx mkBasicTxBody
& bodyTxL . certsTxBodyL
.~ [regTxCert, delegStakeTxCert (KeyHashObj kh) poolKh]
expectDelegatedToPool (KeyHashObj kh) poolKh
cred <- KeyHashObj <$> freshKeyHash
regTxCert <- genRegTxCert cred
submitTx_ $
mkBasicTx mkBasicTxBody
& bodyTxL . certsTxBodyL
.~ [regTxCert, delegStakeTxCert cred poolKh]
expectDelegatedToPool cred poolKh

it "Delegate unregistered stake credentials" $ do
cred <- KeyHashObj <$> freshKeyHash
Expand Down