Skip to content

Conversation

@Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Sep 1, 2025

Description

Follow-up to #5220 and #5137 @teodanciu addressed everything and then some that was originally part of this PR in #5330, so this PR is now reduced to a minor cleanup post-#5330.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky force-pushed the ldan/shelley-delegspec branch from d5e6d83 to 1a163af Compare September 19, 2025 12:27
@Lucsanszky Lucsanszky marked this pull request as ready for review September 19, 2025 12:32
@Lucsanszky Lucsanszky requested a review from a team as a code owner September 19, 2025 12:32
@Lucsanszky Lucsanszky changed the base branch from master to ldan/imptest-improvements September 19, 2025 12:36
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 10 times, most recently from 3c72d20 to e2ea84f Compare September 29, 2025 15:51
Base automatically changed from ldan/imptest-improvements to master September 29, 2025 17:37
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-delegspec branch from 1a163af to 459093e Compare October 7, 2025 17:18
@Lucsanszky Lucsanszky mentioned this pull request Oct 9, 2025
10 tasks
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-delegspec branch from 459093e to 5bac52a Compare October 21, 2025 12:30
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-delegspec branch from 5bac52a to c1b646f Compare October 21, 2025 19:11
@Lucsanszky Lucsanszky changed the title Add DELEG Imp tests for Shelley Remove Deleg.conwayEraSpecificSpec Oct 21, 2025
@Lucsanszky Lucsanszky requested a review from teodanciu October 21, 2025 20:24
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit 0cf935c into master Oct 22, 2025
122 checks passed
@lehins lehins deleted the ldan/shelley-delegspec branch October 22, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants