Run Imp DELEG tests across eras #5330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/delegspec-across-eras
branch
2 times, most recently
from
56e4e23 to
61aeafc
Compare
teodanciu
force-pushed
the
td/delegspec-across-eras
branch
3 times, most recently
from
7107c4d to
5b8de4f
Compare
Lucsanszky
reviewed
Oct 9, 2025
Contributor
Lucsanszky
left a comment
Lucsanszky
left a comment
There was a problem hiding this comment.
I have one small caveat so far. I'll keep reviewing tomorrow. I think this should definitely be merged before mine (#5267).
teodanciu
force-pushed
the
td/delegspec-across-eras
branch
from
6d6829c to
d1ac299
Compare
teodanciu
force-pushed
the
td/delegspec-across-eras
branch
from
d1ac299 to
b27a738
Compare
and run them in all eras until Conway
teodanciu
force-pushed
the
td/delegspec-across-eras
branch
from
b27a738 to
b065c65
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Deleg Imp specs are only written and ran from Conway onwards, even though some functionality is applicable for pre-Conway.
This PR:
* extracts the Deleg tests that are valid for all eras - from conway DelegSpec to a new shelley DelegSpec
* adds some tests that are shelley-specific
To see the changes that made Conway tests compatible to previous eras, see the second commit.
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).