Skip to content

chore(api): drop gateCheckMode from registration-readiness and settings-preview responses - #5454

Merged
JSONbored merged 1 commit into
mainfrom
chore/gatecheckmode-registration-settings-stage2-7
Jul 12, 2026
Merged

chore(api): drop gateCheckMode from registration-readiness and settings-preview responses#5454
JSONbored merged 1 commit into
mainfrom
chore/gatecheckmode-registration-settings-stage2-7

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Stage 2.7 of #5373's staged removal plan.

  • Stops copying settings.gateCheckMode into GithubAppBehavior (registration-readiness.ts) and the settings-preview response object, removing the field from both local report types entirely. Neither surface is a documented public API contract for third-party consumers, confirmed via the Stage and remove the derived-only gateCheckMode field (naming sprawl, #5355 follow-up) #5373 discovery audit: not exported from gittensory-engine's public index.ts, no external self-hosted install (SSH-checked all 3 known ones directly against the dedicated server) references it, and no dedicated test asserted on it in either output.
  • Also fixes 3 OpenAPI schema entries (RepoSettingsPreviewSchema, RegistrationReadinessSchema, and InstallationRepairSchema) that still declared gateCheckMode as present. InstallationRepairSchema has been stale since chore(types): widen gateCheckMode to optional, drop internal-only passthroughs #5440 dropped the field from backfill.ts's summarizeRepairSettings but never updated its schema -- caught here while auditing the other two. Regenerated openapi.json. RepositorySettingsSchema itself is untouched since RepositorySettings.gateCheckMode still exists (optional) at this stage.

Test plan

  • npm run typecheck
  • npm run docs:drift-check
  • npm run ui:openapi:settings-parity
  • test/unit/registration-readiness.test.ts, settings-preview.test.ts, self-dogfood-registration-pack.test.ts, repo-policy-readiness.test.ts, backfill.test.ts, backfill-2.test.ts -- 321/321

…gs-preview responses (#5373)

Stops copying settings.gateCheckMode into GithubAppBehavior
(registration-readiness.ts) and the settings-preview response object,
removing the field from both local report types entirely. Neither
surface is a documented public API contract for third-party
consumers, confirmed via the #5373 discovery audit: not exported from
gittensory-engine's public index, no external self-hosted install (all
3 known ones checked directly) references it, and no dedicated test
asserted on it in either output.

Also fixes 3 OpenAPI schema entries (RepoSettingsPreviewSchema,
RegistrationReadinessSchema, and InstallationRepairSchema) that still
declared gateCheckMode as present -- InstallationRepairSchema has been
stale since #5440 dropped the field from backfill.ts's
summarizeRepairSettings but never updated its schema. Regenerated
openapi.json; RepositorySettingsSchema itself is untouched since
RepositorySettings.gateCheckMode still exists (optional) at this stage.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui 6ab32a0 Commit Preview URL

Branch Preview URL
Jul 12 2026, 08:00 PM

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.44%. Comparing base (65fa28b) to head (6ab32a0).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5454      +/-   ##
==========================================
- Coverage   94.48%   94.44%   -0.04%     
==========================================
  Files         554      554              
  Lines       44450    44450              
  Branches    14663    14663              
==========================================
- Hits        41999    41982      -17     
- Misses       1776     1793      +17     
  Partials      675      675              
Flag Coverage Δ
shard-1 43.82% <ø> (-0.27%) ⬇️
shard-2 34.92% <ø> (-0.03%) ⬇️
shard-3 31.68% <ø> (-0.29%) ⬇️
shard-4 31.36% <ø> (+0.09%) ⬆️
shard-5 33.25% <ø> (-0.06%) ⬇️
shard-6 43.76% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/openapi/schemas.ts 100.00% <ø> (ø)
src/signals/registration-readiness.ts 98.55% <ø> (ø)
src/signals/settings-preview.ts 98.63% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@loopover-orb

loopover-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-12 20:09:35 UTC

5 files · 1 AI reviewer · 1 blocker · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is stage 2.7 of a staged deprecated-field removal: it stops copying settings.gateCheckMode into GithubAppBehavior and RepoSettingsPreview, drops the field from those two local report types plus their Zod schemas, and fixes a third schema (InstallationRepairSchema) that had drifted from backfill.ts since #5440. The changes are internally consistent — schema, type, and producer sites for the same field are updated together, openapi.json is regenerated to match, and the affected test fixtures drop the now-absent property. RepositorySettings.gateCheckMode itself is untouched, so this is a surface-level removal only, matching the description.

Nits — 5 non-blocking

Concerns raised — review before merging

  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Signal Result Evidence
Code review ❌ 1 blocker 1 reviewer
Linked issue ✅ No-issue rationale PR body explains why no issue is linked.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 457 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 457 issue(s).
Gate result ❌ Blocking Repo-configured hard blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 44 PR(s), 457 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before / after /
/ mobile before / (mobile) after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 12, 2026
@JSONbored
JSONbored merged commit 2d49c5c into main Jul 12, 2026
19 checks passed
@JSONbored
JSONbored deleted the chore/gatecheckmode-registration-settings-stage2-7 branch July 12, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant