chore(api): drop gateCheckMode from registration-readiness and settings-preview responses - #5454
Conversation
…gs-preview responses (#5373) Stops copying settings.gateCheckMode into GithubAppBehavior (registration-readiness.ts) and the settings-preview response object, removing the field from both local report types entirely. Neither surface is a documented public API contract for third-party consumers, confirmed via the #5373 discovery audit: not exported from gittensory-engine's public index, no external self-hosted install (all 3 known ones checked directly) references it, and no dedicated test asserted on it in either output. Also fixes 3 OpenAPI schema entries (RepoSettingsPreviewSchema, RegistrationReadinessSchema, and InstallationRepairSchema) that still declared gateCheckMode as present -- InstallationRepairSchema has been stale since #5440 dropped the field from backfill.ts's summarizeRepairSettings but never updated its schema. Regenerated openapi.json; RepositorySettingsSchema itself is untouched since RepositorySettings.gateCheckMode still exists (optional) at this stage.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 6ab32a0 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 08:00 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5454 +/- ##
==========================================
- Coverage 94.48% 94.44% -0.04%
==========================================
Files 554 554
Lines 44450 44450
Branches 14663 14663
==========================================
- Hits 41999 41982 -17
- Misses 1776 1793 +17
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-12 20:09:35 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agent
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|


Summary
Stage 2.7 of #5373's staged removal plan.
settings.gateCheckModeintoGithubAppBehavior(registration-readiness.ts) and the settings-preview response object, removing the field from both local report types entirely. Neither surface is a documented public API contract for third-party consumers, confirmed via the Stage and remove the derived-only gateCheckMode field (naming sprawl, #5355 follow-up) #5373 discovery audit: not exported fromgittensory-engine's publicindex.ts, no external self-hosted install (SSH-checked all 3 known ones directly against the dedicated server) references it, and no dedicated test asserted on it in either output.RepoSettingsPreviewSchema,RegistrationReadinessSchema, andInstallationRepairSchema) that still declaredgateCheckModeas present.InstallationRepairSchemahas been stale since chore(types): widen gateCheckMode to optional, drop internal-only passthroughs #5440 dropped the field frombackfill.ts'ssummarizeRepairSettingsbut never updated its schema -- caught here while auditing the other two. Regeneratedopenapi.json.RepositorySettingsSchemaitself is untouched sinceRepositorySettings.gateCheckModestill exists (optional) at this stage.Test plan
npm run typechecknpm run docs:drift-checknpm run ui:openapi:settings-paritytest/unit/registration-readiness.test.ts,settings-preview.test.ts,self-dogfood-registration-pack.test.ts,repo-policy-readiness.test.ts,backfill.test.ts,backfill-2.test.ts-- 321/321