Skip to content

chore(api): drop gateCheckMode from registration-readiness and settings-preview responses #5454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 12, 2026
Merged

chore(api): drop gateCheckMode from registration-readiness and settings-preview responses #5454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions apps/gittensory-ui/public/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3862,13 +3862,6 @@
"enabled"
]
},
"gateCheckMode": {
"type": "string",
"enum": [
"off",
"enabled"
]
},
"reviewCheckMode": {
"type": "string",
"enum": [
Expand Down Expand Up @@ -9742,13 +9735,6 @@
"enabled"
]
},
"gateCheckMode": {
"type": "string",
"enum": [
"off",
"enabled"
]
},
"reviewCheckMode": {
"type": "string",
"enum": [
Expand Down Expand Up @@ -10170,13 +10156,6 @@
"standard"
]
},
"gateCheckMode": {
"type": "string",
"enum": [
"off",
"enabled"
]
},
"regateSweepOrderMode": {
"type": "string",
"enum": [
Expand Down
9 changes: 0 additions & 9 deletions src/openapi/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,9 +887,6 @@ export const RepoSettingsPreviewSchema = z
publicSignalLevel: z.enum(["minimal", "standard"]),
checkRunMode: z.enum(["off", "enabled"]),
checkRunDetailLevel: z.enum(["minimal", "standard"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]).optional(),
regateSweepOrderMode: z.enum(["staleness", "oldest-first"]),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
Expand Down Expand Up @@ -1292,9 +1289,6 @@ export const InstallationRepairSchema = z
commentMode: z.enum(["off", "detected_contributors_only", "all_prs"]),
publicAudienceMode: z.enum(["oss_maintainer", "gittensor_only"]),
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]).optional(),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
autoProjectMilestoneMatchBackend: z.enum(["github", "linear"]).optional(),
Expand Down Expand Up @@ -2213,9 +2207,6 @@ export const RegistrationReadinessSchema = z
commentMode: z.enum(["off", "detected_contributors_only", "all_prs"]),
publicAudienceMode: z.enum(["oss_maintainer", "gittensor_only"]),
checkRunMode: z.enum(["off", "enabled"]),
// @deprecated (#4618, tracked for removal in #5373): computed read-back of reviewCheckMode kept only
// for API/dashboard back-compat display -- read reviewCheckMode instead.
gateCheckMode: z.enum(["off", "enabled"]).optional(),
reviewCheckMode: z.enum(["required", "visible", "disabled"]),
autoProjectMilestoneMatch: z.enum(["off", "suggest", "auto"]).optional(),
autoProjectMilestoneMatchBackend: z.enum(["github", "linear"]).optional(),
Expand Down
4 changes: 0 additions & 4 deletions src/signals/registration-readiness.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ export type GithubAppBehavior = {
commentMode: RepositorySettings["commentMode"];
publicAudienceMode: RepositorySettings["publicAudienceMode"];
checkRunMode: RepositorySettings["checkRunMode"];
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode} kept
* only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: RepositorySettings["gateCheckMode"];
reviewCheckMode: RepositorySettings["reviewCheckMode"];
quietByDefault: boolean;
behavior: string;
Expand Down Expand Up @@ -132,7 +129,6 @@ function buildGithubAppBehavior(repo: RepositoryRecord | null, settings: Reposit
commentMode: settings.commentMode,
publicAudienceMode: settings.publicAudienceMode,
checkRunMode: settings.checkRunMode,
gateCheckMode: settings.gateCheckMode,
reviewCheckMode: settings.reviewCheckMode,
quietByDefault,
behavior: !installed
Expand Down
4 changes: 0 additions & 4 deletions src/signals/settings-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,6 @@ export type RepoSettingsPreview = {
publicSignalLevel: RepositorySettings["publicSignalLevel"];
checkRunMode: RepositorySettings["checkRunMode"];
checkRunDetailLevel: RepositorySettings["checkRunDetailLevel"];
/** @deprecated (#4618, tracked for removal in #5373) computed read-back of {@link reviewCheckMode}
* kept only for API/dashboard back-compat display -- read `reviewCheckMode` instead. */
gateCheckMode: RepositorySettings["gateCheckMode"];
regateSweepOrderMode: RepositorySettings["regateSweepOrderMode"];
reviewCheckMode: RepositorySettings["reviewCheckMode"];
gatePack: RepositorySettings["gatePack"];
Expand Down Expand Up @@ -328,7 +325,6 @@ export function buildRepoSettingsPreview(args: {
publicSignalLevel: settings.publicSignalLevel,
checkRunMode: settings.checkRunMode,
checkRunDetailLevel: settings.checkRunDetailLevel,
gateCheckMode: settings.gateCheckMode,
regateSweepOrderMode: settings.regateSweepOrderMode,
reviewCheckMode: settings.reviewCheckMode,
gatePack: settings.gatePack,
Expand Down
3 changes: 0 additions & 3 deletions test/unit/self-dogfood-registration-pack.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ function settingsFor(repoFullName: string, overrides: Partial<RepositorySettings
publicSignalLevel: "standard",
checkRunMode: "enabled",
checkRunDetailLevel: "standard",
gateCheckMode: "off",
regateSweepOrderMode: "staleness",
reviewCheckMode: "disabled",
gatePack: "gittensor",
Expand Down Expand Up @@ -170,7 +169,6 @@ function readinessFixture(overrides: Partial<RegistrationReadinessReport> = {}):
commentMode: "all_prs",
publicAudienceMode: "oss_maintainer",
checkRunMode: "off",
gateCheckMode: "off",
reviewCheckMode: "disabled",
quietByDefault: false,
behavior: "Gittensory would stay silent because the GitHub App is not installed.",
Expand Down Expand Up @@ -367,7 +365,6 @@ describe("buildSelfDogfoodRegistrationPack", () => {
commentMode: "all_prs",
publicAudienceMode: "oss_maintainer",
checkRunMode: "off",
gateCheckMode: "off",
reviewCheckMode: "disabled",
quietByDefault: false,
behavior: "Gittensory posts comment and label in oss maintainer mode, for all PRs.",
Expand Down
Loading