Skip to content

docs(queue): fix reconcileLiveDuplicateSiblings stale comment - #7817

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kai392:fix/7810-reconcile-doc-comment
Jul 21, 2026
Merged

docs(queue): fix reconcileLiveDuplicateSiblings stale comment#7817
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kai392:fix/7810-reconcile-doc-comment

Conversation

@kai392

@kai392 kai392 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #7810

Test plan

  • Comment-only change; existing reconcile-live-duplicate-siblings tests already document the correct claim-time semantics.
  • No code formatting changes beyond the comment block.

@kai392
kai392 requested a review from JSONbored as a code owner July 21, 2026 13:18
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Describe claim-time duplicate-winner election (JSONbored#3816) instead of the obsolete PR-number-based wording. Closes JSONbored#7810.

Co-authored-by: Cursor <cursoragent@cursor.com>
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (ea7da0c) to head (eb251e4).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7817      +/-   ##
==========================================
  Coverage   88.57%   88.58%              
==========================================
  Files         725       84     -641     
  Lines       76409    20697   -55712     
  Branches    22762     3662   -19100     
==========================================
- Hits        67682    18335   -49347     
+ Misses       7681     2184    -5497     
+ Partials     1046      178     -868     
Flag Coverage Δ
shard-1 57.57% <ø> (+2.16%) ⬆️
shard-2 100.00% <ø> (+47.42%) ⬆️
shard-3 24.24% <ø> (-23.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/queue/duplicate-detection.ts 100.00% <ø> (ø)

... and 641 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 21, 2026
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-21 13:30:01 UTC

1 file · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a comment-only doc fix to reconcileLiveDuplicateSiblings, updating the stale description that claimed only lower-numbered siblings can demote the current PR — the actual filter (line ~99-103 of the full file) has no number-direction restriction and the existing test suite (reconcile-live-duplicate-siblings.test.ts) already exercises the higher-number-demotes-lower case, confirming the new comment matches real behavior. No code changed, so there is no behavioral risk; this is a pure accuracy fix aligned with #3816 claim-time election semantics.

Nits — 3 non-blocking

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7810
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 31 registered-repo PR(s), 21 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kai392; Gittensor profile; 31 PR(s), 0 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The diff rewrites the doc comment to explicitly describe claim-time-based election where any overlapping sibling (lower or higher PR number) can demote the current PR, citing #3816, and removes the stale 'lower-numbered only' and 'LOWER-numbered' language exactly as requested.

Review context
  • Author: kai392
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: JavaScript, Kotlin, Perl, TypeScript, Vue
  • Official Gittensor activity: 31 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 3fd145b into JSONbored:main Jul 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale doc comment on reconcileLiveDuplicateSiblings describes pre-#3816 PR-number election, not the real claim-time semantics

2 participants