Skip to content

docs(queue): fix reconcileLiveDuplicateSiblings stale comment #7817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 21, 2026
Merged

docs(queue): fix reconcileLiveDuplicateSiblings stale comment #7817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/queue/duplicate-detection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,16 @@ export function dupWinnerLinkedDuplicateWinnerNumber(
* Live-reconcile the duplicate cluster's open siblings before the winner is elected (#dup-winner / audit #15).
*
* The stored open-PR cache ({@link listOtherOpenPullRequests}) lags GitHub: a sibling that was closed/merged on
* GitHub but is still cached `open` would keep "winning" the duplicate cluster, demoting the real lowest-OPEN PR
* to a loser and auto-closing it via the `duplicate_pr_risk` blocker. Only a LOWER-numbered overlapping sibling
* can demote this PR from winner, so re-fetch the LIVE state of just those siblings and drop any that are no
* longer open. Then the downstream election ({@link isDuplicateClusterWinnerByClaim}) reflects ground truth.
* GitHub but is still cached `open` would keep "winning" the duplicate cluster, demoting the true earliest
* claimant to a loser and auto-closing it via the `duplicate_pr_risk` blocker. Duplicate-winner election is
* claim-time based ({@link resolveDuplicateClusterWinnerNumber}, #3816): any overlapping sibling — lower or
* higher PR number — can demote this PR if it claimed the linked issue earlier, so re-fetch the LIVE state of
* all overlapping siblings and drop any that are no longer open. Then the downstream election
* ({@link isDuplicateClusterWinnerByClaim}) reflects ground truth.
*
* FAIL-OPEN to the stored state: a sibling is dropped ONLY on a positive "not open" confirmation — an unreadable
* live fetch keeps it, so a transient GitHub hiccup never newly spares a real loser. Flag-OFF (default), no
* linked issues, or no lower overlapping sibling ⇒ returns the input unchanged with no extra API calls.
* linked issues, or no overlapping sibling ⇒ returns the input unchanged with no extra API calls.
*/
export async function reconcileLiveDuplicateSiblings(
env: Env,
Expand Down