fix(ci): stop setup-workspace citing the removed validate-tests-merge job - #8702
Conversation
… job The setup-workspace action's header comment and its save-cache input description both described a validate-tests-merge job that was folded into validate-tests during the 2026-07-24 CI unsharding consolidation. Keep save-cache as a general-purpose escape hatch and reword both comments to describe the current two-job topology; no caller passes save-cache, so runtime behavior is unchanged. Closes JSONbored#8693
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8702 +/- ##
==========================================
- Coverage 93.77% 92.22% -1.56%
==========================================
Files 797 797
Lines 79467 79467
Branches 24071 24071
==========================================
- Hits 74517 73285 -1232
- Misses 3565 5099 +1534
+ Partials 1385 1083 -302
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-26 00:08:46 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
What
.github/actions/setup-workspace/action.yml's header comment and itssave-cacheinputdescription both cited a
validate-tests-mergejob that no longer exists — it was folded intovalidate-testsduring the 2026-07-24 CI unsharding consolidation (seeci.yml:958: "the separatevalidate-tests-mergejob now just... runs here").Choice made and why
Kept the
save-cacheinput and rewrote its stale documentation (rather than deleting it). Theinput is a genuine general-purpose escape hatch: a future read-only cache-consumer job would set
save-cache: "false"to avoid a redundant save. Keeping it preserves that capability, and acomments-only edit carries zero runtime risk to a load-bearing shared action.
validate-codeandvalidate-tests(the two current callers), dropping the removed third job.
save-cachedescription: now describes its real current purpose — a default-"true"escape hatchfor a read-only consumer — and notes no live caller overrides the default.
Caller safety (grep-confirmed)
save-cacheis referenced only insideaction.ymlitself:None of the 5 current callers (
ci.yml×2,orb-stable-release-pr.yml,package-release-watch.yml,orb-beta-release.yml,mcp-release-watch.yml) passsave-cache, so all keep the"true"default.The input's runtime (line 79) is untouched — behavior is identical for every caller.
Test coverage
CI-configuration/documentation-only change with no application-code behavioral change; per the issue,
the verification is the grep-based caller check above. YAML parses and
prettier --checkpasses.Closes #8693