Skip to content

fix(ci): stop setup-workspace citing the removed validate-tests-merge job #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 26, 2026
Merged

fix(ci): stop setup-workspace citing the removed validate-tests-merge job #8702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/actions/setup-workspace/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Setup workspace
description: >-
Strip untrusted npm config, set up Node, and restore/install/save the fork/trusted-scoped
node_modules cache. Extracted from ci.yml's validate-code, validate-tests, and validate-tests-merge
jobs, which had this exact sequence copy-pasted three times -- the same kind of drift that caused a
node_modules cache. Extracted from ci.yml's validate-code and validate-tests jobs, which had this
exact sequence copy-pasted at each site -- the same kind of drift that caused a
real cache-key mismatch bug this repo already hit once (two jobs' Turborepo cache pair silently
diverged when one was edited and the other wasn't). This doesn't fix that specific bug on its own,
but a future change to this sequence now only needs to happen here, not be remembered at every call
Expand All @@ -13,9 +13,10 @@ description: >-
inputs:
save-cache:
description: >-
Whether to save the node_modules cache after a successful install. validate-tests-merge sets
this to "false" -- it only ever reads the cache validate-code/validate-tests already populate,
never writes to it, so a save here would just be redundant work.
Whether to save the node_modules cache after a successful install (default "true"). A
general-purpose escape hatch: set it to "false" in a job that should only ever read a cache
another job already populated and never write one -- a save there would just be redundant work.
No current caller overrides the default; every live caller both restores and saves.
required: false
default: "true"

Expand Down