test(ui): cover miner-commands redaction and action branches - #8756
Closed
philluiz2323 wants to merge 2 commits into
Closed
test(ui): cover miner-commands redaction and action branches#8756philluiz2323 wants to merge 2 commits into
philluiz2323 wants to merge 2 commits into
Conversation
Add a dedicated miner-commands.test.ts exercising sanitizeMinerCommand's forbidden-term and path redaction plus every buildMinerCommandActions state branch; export sanitizeMinerCommand for direct unit coverage. Closes #8677
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 LoopOver is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/loopover-ui/src/lib/miner-commands.test.tscoveringsanitizeMinerCommand(each forbiddenterm=value/term: valuecategory, passthrough, name-token non-corruption, and local-path redaction) and everybuildMinerCommandActionsstate branch.sanitizeMinerCommandso the redaction contract can be unit-tested directly (it was previously private and only reached indirectly viaminer-panel.test.tsx).Closes #8677
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm --workspace @loopover/ui run test -- src/lib/miner-commands.test.ts(9 passed)npm run actionlint— not applicablenpm run typecheck— not applicable (UI test/export only)npm run test:coverage— not applicable (apps/**excluded fromcodecov/patch; UI vitest coverage exercised above)npm run test:workers— not applicablenpm run build:mcp— not applicablenpm run test:mcp-pack— not applicablenpm run ui:openapi:check— not applicablenpm run ui:lint— skipped locally; no formatting-sensitive UI component changes beyond a one-line exportnpm run ui:typecheck— skipped locally; export is a visibility change onlynpm run ui:build— not applicable for this test-only PRnpm audit --audit-level=moderate— not applicableIf any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable — no visible UI change (test coverage + export only).
Notes