Skip to content

test(ui): cover miner-commands redaction and action branches - #8769

Merged
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
philluiz2323:test/8677-miner-commands-redaction-coverage-v2
Jul 26, 2026
Merged

test(ui): cover miner-commands redaction and action branches#8769
loopover-orb[bot] merged 2 commits into
JSONbored:mainfrom
philluiz2323:test/8677-miner-commands-redaction-coverage-v2

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

Summary

  • Add dedicated apps/loopover-ui/src/lib/miner-commands.test.ts covering sanitizeMinerCommand (forbidden term=value / term: value categories, passthrough, name-token non-corruption, local-path redaction) and every buildMinerCommandActions state branch.
  • Export sanitizeMinerCommand for direct unit coverage.
  • Prettier/LF formatted so ui:lint passes (resubmit of closed test(ui): cover miner-commands redaction and action branches #8756).

Closes #8677

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm --workspace @loopover/ui exec -- eslint src/lib/miner-commands.test.ts (exit 0)
  • npm --workspace @loopover/ui run test -- src/lib/miner-commands.test.ts (9 passed)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — test coverage + export only.

Notes

Add a dedicated miner-commands.test.ts exercising sanitizeMinerCommand's forbidden-term and path redaction plus every buildMinerCommandActions state branch; export sanitizeMinerCommand for direct unit coverage.

Closes #8677
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-26 03:34:06 UTC

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a minimal, well-scoped test-only PR: it exports the previously-private `sanitizeMinerCommand` for direct unit testing and adds a dedicated spec file covering redaction categories, path sanitization, and every `buildMinerCommandActions` state branch. The tests are accurate against the real implementation shown in the full file content — the redaction categories, path patterns, and state transitions (setup/ready/needs_login/needs_repo) all match the source in miner-commands.ts, so this isn't fabricated coverage. The `raw-trust`/`raw_trust` test cases use a slightly loose regex boundary but correctly verify redaction against the real regex source.

Nits — 5 non-blocking
  • apps/loopover-ui/src/lib/miner-commands.test.ts: the `banned` regexes for `raw-trust: 1` / `raw_trust=1` (`/:\s*1\b/`, `/=\s*1\b/`) are looser than needed — they'd also match unrelated `: 1` or `= 1` substrings elsewhere in the string, though in this fixed-string test that risk is currently zero.
  • The new test file duplicates significant coverage already present in test/unit/miner-dashboard-commands.test.ts (same login/repo state-branch assertions) — consider noting the overlap in the PR description since both suites will need to stay in sync going forward.
  • apps/loopover-ui/src/lib/miner-commands.ts:84: making `sanitizeMinerCommand` exported broadens its public surface permanently for the sake of one test file; an alternative would be to test it only indirectly via `buildMinerCommandActions`, though direct unit coverage of the redaction boundary is reasonable here.
  • Consider tightening the `raw-trust`/`raw_trust` test regexes to anchor more specifically to the redacted value context, e.g. matching against the pre-redaction leak string directly rather than a generic `\b1\b` pattern.
  • Since test/unit/miner-dashboard-commands.test.ts already covers action-branch behavior end-to-end, the new file could focus solely on `sanitizeMinerCommand` boundary cases to reduce duplication, or the older file could be trimmed.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8756, #8677
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (2 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1025 registered-repo PR(s), 601 merged, 126 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 1025 PR(s), 126 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The PR adds a dedicated test file covering sanitizeMinerCommand's forbidden-term redaction categories, passthrough, name-token safety, and local-path redaction, plus tests for every buildMinerCommandActions state branch, and exports sanitizeMinerCommand as requested so it can be tested directly.

Review context
  • Author: philluiz2323
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
  • Official Gittensor activity: 1025 PR(s), 126 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit cdd760d into JSONbored:main Jul 26, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ui): miner-commands.ts's sensitive-term redaction logic has zero direct test coverage

1 participant