test(ui): cover miner-commands redaction and action branches - #8769
Conversation
Add a dedicated miner-commands.test.ts exercising sanitizeMinerCommand's forbidden-term and path redaction plus every buildMinerCommandActions state branch; export sanitizeMinerCommand for direct unit coverage. Closes #8677
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-26 03:34:06 UTC
Review summary Nits — 5 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
apps/loopover-ui/src/lib/miner-commands.test.tscoveringsanitizeMinerCommand(forbiddenterm=value/term: valuecategories, passthrough, name-token non-corruption, local-path redaction) and everybuildMinerCommandActionsstate branch.sanitizeMinerCommandfor direct unit coverage.ui:lintpasses (resubmit of closed test(ui): cover miner-commands redaction and action branches #8756).Closes #8677
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm --workspace @loopover/ui exec -- eslint src/lib/miner-commands.test.ts(exit 0)npm --workspace @loopover/ui run test -- src/lib/miner-commands.test.ts(9 passed)If any required check was skipped, explain why:
Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable — test coverage + export only.
Notes